<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "http://pkp.sfu.ca/bugzilla/bugzilla.dtd">

<bugzilla version="4.2.5+"
          urlbase="http://pkp.sfu.ca/bugzilla/"
          
          maintainer="pkp-hosted@sfu.ca"
>

    <bug>
          <bug_id>6747</bug_id>
          
          <creation_ts>2011-07-08 17:13:00 -0700</creation_ts>
          <short_desc>reviewer and review pages are all kinds of broken</short_desc>
          <delta_ts>2011-09-05 17:50:41 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>OMP</product>
          <component>Reviewers</component>
          <version>1.0</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P3</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Juan Pablo Alperin">juan</reporter>
          <assigned_to name="Juan Pablo Alperin">juan</assigned_to>
          <cc>alec</cc>
    
    <cc>jerico.dev</cc>
    
    <cc>mattcrider</cc>
    
    <cc>pkp-support</cc>
          
          

      

      

      

          <long_desc isprivate="0">
            <commentid>24296</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-07-08 17:13:53 -0700</bug_when>
            <thetext>the grid is not working properly, the steps aren&apos;t submitting correctly. all kinds of broken.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24321</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-07-11 13:11:40 -0700</bug_when>
            <thetext>*** Bug 6410 has been marked as a duplicate of this bug. ***</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24323</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-07-11 14:34:27 -0700</bug_when>
            <thetext>Reviewer pages (mostly markup)
https://github.com/pkp/omp/commit/41af6051132712c7cdfe8bd8628d236d5ba3da9d

Reviewer Grid:
https://github.com/pkp/omp/commit/6f93952fd71c9a5808c975b508794c069650864d

Mostly to Review Forms:
https://github.com/pkp/omp/commit/da6d84de80da6e6ea41d1d05320877605766c006

ReviewRoundForm:
https://github.com/pkp/omp/commit/ad42084a5b0f213cad64f1e6901c49ecfd7e67df

Workflow Handler changes (including reviewType-&gt;stageId, bug #6244#)
https://github.com/pkp/omp/commit/9ea047080e3f5efae7fbbb5fac029f62c0a244b2</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24335</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-07-11 22:53:11 -0700</bug_when>
            <thetext>*** Bug 6374 has been marked as a duplicate of this bug. ***</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24343</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-07-11 23:10:32 -0700</bug_when>
            <thetext>*** Bug 6531 has been marked as a duplicate of this bug. ***</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24385</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-07-14 15:24:14 -0700</bug_when>
            <thetext>*** Bug 6172 has been marked as a duplicate of this bug. ***</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24505</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-07-21 14:50:04 -0700</bug_when>
            <thetext>MONOGRAPH_FILE constants unecessary using hex (renumber all and introduce review_attachment constant)
https://github.com/pkp/omp/commit/3d5390f873056b993ddc4ede5e1e67d58be1020c</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24506</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-07-21 14:50:04 -0700</bug_when>
            <thetext>include assocType/assocId in file upload and management classes
https://github.com/pkp/omp/commit/825d032cafdc362221bfbb20ebe473e6927b9876</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24507</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-07-21 14:50:05 -0700</bug_when>
            <thetext>introduce more options to PKPSubmissionFileDAO::_getInternally (uploaderId/UserGroupId, assocType/Id)
https://github.com/pkp/pkp-lib/commit/6fd65bed4ba7048e6080d94a21b3dc17ec034696</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24508</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-07-21 14:50:05 -0700</bug_when>
            <thetext>include revision in review_round_files primary key
https://github.com/pkp/omp/commit/980651d63e366b3debc5040d4a62506f2dd2c211</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24509</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-07-21 14:50:05 -0700</bug_when>
            <thetext>make grids load the right files and just generally work. Also fix editor decision forms.
https://github.com/pkp/omp/commit/40bff10eb2ee13d697065db28c0ebfe5036672ff</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24510</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-07-21 14:50:05 -0700</bug_when>
            <thetext>make revisions across stages get a new file id and point the source to the revision.
https://github.com/pkp/omp/commit/42788345560fc61ff4564e9f638a7b3007f8632e</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24511</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-07-21 14:50:05 -0700</bug_when>
            <thetext>introduce fileStage = REVIEW_ATTACHMENT (not used yet)
https://github.com/pkp/omp/commit/c1f8dbfd90c4fb57aa856657b1c99f538a8ff5c1</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24512</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-07-21 14:50:05 -0700</bug_when>
            <thetext>Fixes to file uploading and new MonographFileManager::copyFileToFileStage method.
https://github.com/pkp/omp/commit/d3a14e81acc013dd0a84d20f03720e925d63574a</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24521</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-07-22 16:30:02 -0700</bug_when>
            <thetext>allow editor decisions to be taken in past stages (lightly tested, but might cause some instability if decisions taken out of order)
https://github.com/pkp/omp/commit/fa8dc8550ef853d603a0dd2fef067a97cc320075</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24581</commentid>
            <who name="beghelli">bruno.beghelli</who>
            <bug_when>2011-08-01 23:50:09 -0700</bug_when>
            <thetext>Template link fix
https://github.com/pkp/omp/commit/230f6f0c0a76f95a886e869dd69a750e3fae83c2</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24650</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-08-04 20:09:39 -0700</bug_when>
            <thetext>*** Bug 6230 has been marked as a duplicate of this bug. ***</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24665</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-08-05 23:50:05 -0700</bug_when>
            <thetext>Review Assignment was not being inserted
https://github.com/pkp/omp/commit/b5e94d7c467538718e651da7993e45d4f2ac1136</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24671</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-08-05 23:50:06 -0700</bug_when>
            <thetext>allow revisions grid to be viewed by authors and update to new definition of FileSignoffGridHandler
https://github.com/pkp/omp/commit/b1a8e687924390ae95611cb5e751d5d01a412796</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24675</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-08-05 23:50:07 -0700</bug_when>
            <thetext>Assign author to Submission Stage
https://github.com/pkp/omp/commit/af71428fa9d9fde68d12c7ab9edab1d61ab34394</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24679</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-08-05 23:50:07 -0700</bug_when>
            <thetext>Misc fixes to review stage
https://github.com/pkp/omp/commit/64677a8035b913d03065784f1faadf46ed91b564</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24694</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-08-07 23:00:10 -0700</bug_when>
            <thetext>flip parameters of ReviewAssignmentRequired policy
https://github.com/pkp/omp/commit/862b0d1a19bdb459676132fc65865379a823d24f</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24763</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-08-09 13:30:25 -0700</bug_when>
            <thetext>*** Bug 6233 has been marked as a duplicate of this bug. ***</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24768</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-08-09 13:37:08 -0700</bug_when>
            <thetext>*** Bug 6412 has been marked as a duplicate of this bug. ***</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24834</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-08-11 21:00:03 -0700</bug_when>
            <thetext>add reviewer modal was not supposed to have tabs. Provide link to other types of adding modals and provide method for reloading form content with other forms.
https://github.com/pkp/omp/commit/d51ba6f0de595f648557a803a4d60557c4628c2d</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24840</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-08-11 21:00:03 -0700</bug_when>
            <thetext>, *6713*, *others* a round of many but minor tune ups to the workflow, mostly visual but some functional
https://github.com/pkp/omp/commit/c3c47f4af195c5ff2270c0efae3a6be7f1f18508</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24841</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-08-11 21:00:04 -0700</bug_when>
            <thetext>editors should not be allowed to add review attachments.
https://github.com/pkp/omp/commit/3c0cbc317eb08b048966329e71648124e4d95490</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24842</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-08-12 00:20:04 -0700</bug_when>
            <thetext>load round tabs via ajax and use TabHandler
https://github.com/pkp/omp/commit/dcd0ad95c56f83cfe8dc5bb080e64d7b351a6429</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24862</commentid>
            <who name="Alec Smecher">alec</who>
            <bug_when>2011-08-12 17:05:02 -0700</bug_when>
            <thetext>SE unassigned list was showing submissions in unassigned series
https://github.com/pkp/omp/commit/bf9f16b81bbf6d2296dfc4a96ce3cc3c9da0f1c4</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24899</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-08-15 22:15:03 -0700</bug_when>
            <thetext>HACK. HACK. hide stage participants and use toggle to show. Plus
https://github.com/pkp/omp/commit/47f3da59fd0a465e355c934c9c8b92fc5714cb1d</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24902</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-08-15 22:15:03 -0700</bug_when>
            <thetext>prevent id clash in review round info when multiple rounds
https://github.com/pkp/omp/commit/af7e189e2aac06d6368131670d6d41bd4b2e0f76</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24903</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-08-15 22:15:03 -0700</bug_when>
            <thetext>ReviewerComment was not fetched correctly. parameters misnamed.
https://github.com/pkp/omp/commit/2a5e131aca1afdf4dbc05a5e48198b3a027d2beb</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24905</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-08-15 22:15:03 -0700</bug_when>
            <thetext>competing interests action
https://github.com/pkp/omp/commit/f40fe6e479aedf89948477906d63b91ef3a2068b</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24987</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-08-22 00:45:10 -0700</bug_when>
            <thetext>various fixes to reviewer grid (cell states, setting response due date, reminder action)
https://github.com/pkp/omp/commit/57c4ef9217c84c642b8f1dc2ca9b7836de13385f</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>25180</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-09-05 17:50:41 -0700</bug_when>
            <thetext>closing in favor of more specific bugs</thetext>
          </long_desc>
      
      

    </bug>

</bugzilla>