6667 2011-06-01 18:00:00 -0700 Upgrade does not mark old version as no longer current 2011-06-21 07:04:28 -0700 1 1 1 Unclassified OJS Installer 2.3.6 All All RESOLVED FIXED P3 normal --- 1 michael.pkp michael.pkp colin.prince pkp-support utkuh 2.3.5 23883 michael.pkp 2011-06-01 18:00:55 -0700 Only the most recently installed version should be marked as current. 23884 3531 michael.pkp 2011-06-01 18:04:37 -0700 Created attachment 3531 Patch against OJS 2.3.5 23885 3532 michael.pkp 2011-06-01 19:00:40 -0700 Created attachment 3532 Patch against OJS 2.3.5 (apply against lib/pkp + see db fix below) 23886 michael.pkp 2011-06-01 19:04:06 -0700 Patch marks old version as no longer current for manual install. Patch restores marking of old version as no longer current in VersionDAO. 23887 michael.pkp 2011-06-01 19:07:19 -0700 Need to manually update versions table to fix this bug after an upgrade to OJS 2.3.5: UPDATE versions SET current = 0 WHERE product = 'ojs2'; UPDATE versions SET current = 1 WHERE product = 'ojs2' AND major = 2 AND minor = 3 AND revision = 5; 23888 michael.pkp 2011-06-01 19:12:23 -0700 Committed to ojs_stable-2_3 and master: https://github.com/pkp/pkp-lib/commit/de0224443d7c683b7506120e4cdd228343ff20bb https://github.com/pkp/pkp-lib/commit/3cd2a49075f7ef0346aca6ac6296446dfb8aa4e4 23992 michael.pkp 2011-06-13 09:34:21 -0700 Additional notes: The fix here reverts patch 3490 in Bug 6579 (Can't move custom blocks). Tested custom blocks on a clean OJS install and customBlockManager version is correctly set to 1 upon install. Custom blocks can also be moved up/down and left/right. 23993 michael.pkp 2011-06-13 09:34:43 -0700 Closing. 3531 2011-06-01 18:04:00 -0700 2011-06-01 19:00:40 -0700 Patch against OJS 2.3.5 6667.diff text/plain 1430 michael.pkp LS0tIGEvY2xhc3Nlcy9pbnN0YWxsL0luc3RhbGxlci5pbmMucGhwCisrKyBiL2NsYXNzZXMvaW5z dGFsbC9JbnN0YWxsZXIuaW5jLnBocApAQCAtMjkwLDEwICsyOTAsMTYgQEAgY2xhc3MgSW5zdGFs bGVyIHsKIAlmdW5jdGlvbiB1cGRhdGVWZXJzaW9uKCkgewogCQlpZiAoJHRoaXMtPm5ld1ZlcnNp b24tPmNvbXBhcmUoJHRoaXMtPmN1cnJlbnRWZXJzaW9uKSA+IDApIHsKIAkJCWlmICgkdGhpcy0+ Z2V0UGFyYW0oJ21hbnVhbEluc3RhbGwnKSkgeworCQkJCS8vIE1hcmsgb2xkIHZlcnNpb24gYXMg bm8gbG9uZ2VyIGN1cnJlbnQKKwkJCQkkdGhpcy0+ZXhlY3V0ZVNRTChzcHJpbnRmKCdVUERBVEUg dmVyc2lvbnMgU0VUIGN1cnJlbnQgPSAwIFdIRVJFIHByb2R1Y3QgPSAlcycsICR0aGlzLT5kYmNv bm4tPnFzdHIoJHRoaXMtPmN1cnJlbnRWZXJzaW9uLT5nZXRQcm9kdWN0KCkpKSk7CisKIAkJCQkv LyBGSVhNRSBXb3VsZCBiZSBiZXR0ZXIgdG8gaGF2ZSBhIG1vZGUgd2hlcmUgJGRiY29ubi0+ZXhl Y3V0ZSgpIHNhdmVzIHRoZSBxdWVyeQogCQkJCXJldHVybiAkdGhpcy0+ZXhlY3V0ZVNRTChzcHJp bnRmKCdJTlNFUlQgSU5UTyB2ZXJzaW9ucyAobWFqb3IsIG1pbm9yLCByZXZpc2lvbiwgYnVpbGQs IGRhdGVfaW5zdGFsbGVkLCBjdXJyZW50LCBwcm9kdWN0X3R5cGUsIHByb2R1Y3QsIHByb2R1Y3Rf Y2xhc3NfbmFtZSwgbGF6eV9sb2FkLCBzaXRld2lkZSkgVkFMVUVTICglZCwgJWQsICVkLCAlZCwg Tk9XKCksIDEsICVzLCAlcywgJXMsICVkLCAlZCknLCAkdGhpcy0+bmV3VmVyc2lvbi0+Z2V0TWFq b3IoKSwgJHRoaXMtPm5ld1ZlcnNpb24tPmdldE1pbm9yKCksICR0aGlzLT5uZXdWZXJzaW9uLT5n ZXRSZXZpc2lvbigpLCAkdGhpcy0+bmV3VmVyc2lvbi0+Z2V0QnVpbGQoKSwgJHRoaXMtPmRiY29u bi0+cXN0cigkdGhpcy0+bmV3VmVyc2lvbi0+Z2V0UHJvZHVjdFR5cGUoKSksICR0aGlzLT5kYmNv bm4tPnFzdHIoJHRoaXMtPm5ld1ZlcnNpb24tPmdldFByb2R1Y3QoKSksICR0aGlzLT5kYmNvbm4t PnFzdHIoJHRoaXMtPm5ld1ZlcnNpb24tPmdldFByb2R1Y3RDbGFzc05hbWUoKSksICgkdGhpcy0+ bmV3VmVyc2lvbi0+Z2V0TGF6eUxvYWQoKT8xOjApLCAoJHRoaXMtPm5ld1ZlcnNpb24tPmdldFNp dGV3aWRlKCk/MTowKSkpOwogCQkJfSBlbHNlIHsKIAkJCQkkdmVyc2lvbkRhbyA9JiBEQU9SZWdp c3RyeTo6Z2V0REFPKCdWZXJzaW9uREFPJyk7CisJCQkJLy8gTWFyayBvbGQgdmVyc2lvbiBhcyBu byBsb25nZXIgY3VycmVudAorCQkJCSR2ZXJzaW9uRGFvLT5kaXNhYmxlVmVyc2lvbigkdGhpcy0+ Y3VycmVudFZlcnNpb24tPmdldFByb2R1Y3QoKSk7CisKIAkJCQlpZiAoISR2ZXJzaW9uRGFvLT5p bnNlcnRWZXJzaW9uKCR0aGlzLT5uZXdWZXJzaW9uKSkgewogCQkJCQlyZXR1cm4gZmFsc2U7CiAJ CQkJfQo= 3532 2011-06-01 19:00:00 -0700 2011-06-01 19:07:55 -0700 Patch against OJS 2.3.5 (apply against lib/pkp + see db fix below) 6667.diff text/plain 2136 michael.pkp ZGlmZiAtLWdpdCBhL2NsYXNzZXMvaW5zdGFsbC9JbnN0YWxsZXIuaW5jLnBocCBiL2NsYXNzZXMv aW5zdGFsbC9JbnN0YWxsZXIuaW5jLnBocAppbmRleCBlN2Y3MDgyLi4yNDg5ZGRjIDEwMDY0NAot LS0gYS9jbGFzc2VzL2luc3RhbGwvSW5zdGFsbGVyLmluYy5waHAKKysrIGIvY2xhc3Nlcy9pbnN0 YWxsL0luc3RhbGxlci5pbmMucGhwCkBAIC0yOTAsNiArMjkwLDkgQEAgY2xhc3MgSW5zdGFsbGVy IHsKIAlmdW5jdGlvbiB1cGRhdGVWZXJzaW9uKCkgewogCQlpZiAoJHRoaXMtPm5ld1ZlcnNpb24t PmNvbXBhcmUoJHRoaXMtPmN1cnJlbnRWZXJzaW9uKSA+IDApIHsKIAkJCWlmICgkdGhpcy0+Z2V0 UGFyYW0oJ21hbnVhbEluc3RhbGwnKSkgeworCQkJCS8vIE1hcmsgb2xkIHZlcnNpb24gYXMgbm8g bG9uZ2VyIGN1cnJlbnQKKwkJCQkkdGhpcy0+ZXhlY3V0ZVNRTChzcHJpbnRmKCdVUERBVEUgdmVy c2lvbnMgU0VUIGN1cnJlbnQgPSAwIFdIRVJFIHByb2R1Y3QgPSAlcycsICR0aGlzLT5kYmNvbm4t PnFzdHIoJHRoaXMtPmN1cnJlbnRWZXJzaW9uLT5nZXRQcm9kdWN0KCkpKSk7CisKIAkJCQkvLyBG SVhNRSBXb3VsZCBiZSBiZXR0ZXIgdG8gaGF2ZSBhIG1vZGUgd2hlcmUgJGRiY29ubi0+ZXhlY3V0 ZSgpIHNhdmVzIHRoZSBxdWVyeQogCQkJCXJldHVybiAkdGhpcy0+ZXhlY3V0ZVNRTChzcHJpbnRm KCdJTlNFUlQgSU5UTyB2ZXJzaW9ucyAobWFqb3IsIG1pbm9yLCByZXZpc2lvbiwgYnVpbGQsIGRh dGVfaW5zdGFsbGVkLCBjdXJyZW50LCBwcm9kdWN0X3R5cGUsIHByb2R1Y3QsIHByb2R1Y3RfY2xh c3NfbmFtZSwgbGF6eV9sb2FkLCBzaXRld2lkZSkgVkFMVUVTICglZCwgJWQsICVkLCAlZCwgTk9X KCksIDEsICVzLCAlcywgJXMsICVkLCAlZCknLCAkdGhpcy0+bmV3VmVyc2lvbi0+Z2V0TWFqb3Io KSwgJHRoaXMtPm5ld1ZlcnNpb24tPmdldE1pbm9yKCksICR0aGlzLT5uZXdWZXJzaW9uLT5nZXRS ZXZpc2lvbigpLCAkdGhpcy0+bmV3VmVyc2lvbi0+Z2V0QnVpbGQoKSwgJHRoaXMtPmRiY29ubi0+ cXN0cigkdGhpcy0+bmV3VmVyc2lvbi0+Z2V0UHJvZHVjdFR5cGUoKSksICR0aGlzLT5kYmNvbm4t PnFzdHIoJHRoaXMtPm5ld1ZlcnNpb24tPmdldFByb2R1Y3QoKSksICR0aGlzLT5kYmNvbm4tPnFz dHIoJHRoaXMtPm5ld1ZlcnNpb24tPmdldFByb2R1Y3RDbGFzc05hbWUoKSksICgkdGhpcy0+bmV3 VmVyc2lvbi0+Z2V0TGF6eUxvYWQoKT8xOjApLCAoJHRoaXMtPm5ld1ZlcnNpb24tPmdldFNpdGV3 aWRlKCk/MTowKSkpOwogCQkJfSBlbHNlIHsKZGlmZiAtLWdpdCBhL2NsYXNzZXMvc2l0ZS9WZXJz aW9uREFPLmluYy5waHAgYi9jbGFzc2VzL3NpdGUvVmVyc2lvbkRBTy5pbmMucGhwCmluZGV4IGQ0 MzhkNTIuLjFlOGMxZDAgMTAwNjQ0Ci0tLSBhL2NsYXNzZXMvc2l0ZS9WZXJzaW9uREFPLmluYy5w aHAKKysrIGIvY2xhc3Nlcy9zaXRlL1ZlcnNpb25EQU8uaW5jLnBocApAQCAtMTM5LDcgKzEzOSw4 IEBAIGNsYXNzIFZlcnNpb25EQU8gZXh0ZW5kcyBEQU8gewogCQkJCQkkaXNOZXdWZXJzaW9uID0g ZmFsc2U7CiAJCQkJfSBlbHNlaWYgKCR2ZXJzaW9uLT5jb21wYXJlKCRvbGRWZXJzaW9uKSA9PSAx KSB7CiAJCQkJCS8vIFZlcnNpb24gdG8gaW5zZXJ0IGlzIG5ld2VyIHRoYW4gdGhlIGV4aXN0aW5n IHZlcnNpb24gZW50cnkuCi0JCQkJCS8vIFdlJ2xsIHVwZGF0ZSB0aGUgZXhpc3RpbmcgZW50cnkg YmVsb3cuCisJCQkJCS8vIFdlIHJlc2V0IGV4aXN0aW5nIGVudHJ5LgorCQkJCQkkdGhpcy0+dXBk YXRlKCdVUERBVEUgdmVyc2lvbnMgU0VUIGN1cnJlbnQgPSAwIFdIRVJFIGN1cnJlbnQgPSAxIEFO RCBwcm9kdWN0ID0gPycsICR2ZXJzaW9uLT5nZXRQcm9kdWN0KCkpOwogCQkJCX0gZWxzZSB7CiAJ CQkJCS8vIFdlIGRvIG5vdCBzdXBwb3J0IGRvd25ncmFkZXMuCiAJCQkJCWZhdGFsRXJyb3IoJ1lv dSBhcmUgdHJ5aW5nIHRvIGRvd25ncmFkZSB0aGUgcHJvZHVjdCAiJy4kdmVyc2lvbi0+Z2V0UHJv ZHVjdCgpLiciIGZyb20gdmVyc2lvbiBbJy4kb2xkVmVyc2lvbi0+Z2V0VmVyc2lvblN0cmluZygp LiddIHRvIHZlcnNpb24gWycuJHZlcnNpb24tPmdldFZlcnNpb25TdHJpbmcoKS4nXS4gRG93bmdy YWRlcyBhcmUgbm90IHN1cHBvcnRlZC4nKTsK