6658 2011-05-24 12:20:00 -0700 Upgrade fails during post-install with email templates error 2011-05-24 13:43:54 -0700 1 1 1 Unclassified OJS Installer 2.3.5 All All RESOLVED FIXED P3 normal --- 1 michael.pkp michael.pkp alec pkp-support 2.3.4 23821 michael.pkp 2011-05-24 12:20:15 -0700 All upgrade steps complete successfully, but post-install fails with the following: <snip> [code: Installer Installer::addPluginVersions] [post-install] ERROR: Upgrade failed: DB: ##installer.installParseEmailTemplatesFileError## 23822 michael.pkp 2011-05-24 12:21:59 -0700 This was a side effect of Bug 5837 (wrong upgrade of plugins emailTemplates). After checking for installed email templates, error is raised rather than continuing with the upgrade. 23823 3516 michael.pkp 2011-05-24 12:26:47 -0700 Created attachment 3516 Patch against OJS 2.3.4 This patch needs to be applied against lib/pkp 23824 alec 2011-05-24 12:33:34 -0700 Are you sure, Michael? That fix looks odd to me. I suspect you're running into trouble parsing a plugin's email templates file and I don't think that change will correct it. Were you able to narrow down the problem e.g. to a particular plugin? 23825 michael.pkp 2011-05-24 12:42:20 -0700 Hi Alec, Yes, fix has been tested. I ended up debugging it and found that the problem applied to all plugins with email templates. Turns out this was correctly handled in master but not stable. Will update fix to match master. 23826 3517 michael.pkp 2011-05-24 12:49:41 -0700 Created attachment 3517 Patch #2 against OJS 2.3.4 Subsequent patch based on master branch This patch needs to be applied against lib/pkp 23827 3518 michael.pkp 2011-05-24 13:37:04 -0700 Created attachment 3518 Patch against OJS 2.3.4 (needs to be applied against lib/pkp) This patch needs to be applied against lib/pkp 23828 alec 2011-05-24 13:38:12 -0700 Sounds good, Michael -- thanks. 23829 michael.pkp 2011-05-24 13:41:42 -0700 Committed to pkp-lib:ojs-stable-2_3 https://github.com/pkp/pkp-lib/commit/e5794b98193bc0c3270565477a15013623180937 https://github.com/pkp/pkp-lib/commit/0a59124c27296e288615284b5665dcbfdac43d81 3516 2011-05-24 12:26:00 -0700 2011-05-24 13:37:04 -0700 Patch against OJS 2.3.4 6658.diff text/plain 739 michael.pkp LS0tIGEvY2xhc3Nlcy9wbHVnaW5zL1BLUFBsdWdpbi5pbmMucGhwCisrKyBiL2NsYXNzZXMvcGx1 Z2lucy9QS1BQbHVnaW4uaW5jLnBocApAQCAtNTQ2LDkgKzU0NiwxMCBAQCBjbGFzcyBQS1BQbHVn aW4gewogCQkkc3FsID0gJGVtYWlsVGVtcGxhdGVEYW8tPmluc3RhbGxFbWFpbFRlbXBsYXRlcygk dGhpcy0+Z2V0SW5zdGFsbEVtYWlsVGVtcGxhdGVzRmlsZSgpLCB0cnVlLCBudWxsLCB0cnVlKTsK IAkJaWYgKCRzcWwpIHsKIAkJCSRyZXN1bHQgPSAkaW5zdGFsbGVyLT5leGVjdXRlU1FMKCRzcWwp OwotCQl9IGVsc2UgewotCQkJJGluc3RhbGxlci0+c2V0RXJyb3IoSU5TVEFMTEVSX0VSUk9SX0RC LCBzdHJfcmVwbGFjZSgneyRmaWxlfScsICR0aGlzLT5nZXRJbnN0YWxsRGF0YUZpbGUoKSwgTG9j YWxlOjp0cmFuc2xhdGUoJ2luc3RhbGxlci5pbnN0YWxsUGFyc2VFbWFpbFRlbXBsYXRlc0ZpbGVF cnJvcicpKSk7Ci0JCQkkcmVzdWx0ID0gZmFsc2U7CisJCQlpZiAoISRyZXN1bHQpIHsKKwkJCQkk aW5zdGFsbGVyLT5zZXRFcnJvcihJTlNUQUxMRVJfRVJST1JfREIsIHN0cl9yZXBsYWNlKCd7JGZp bGV9JywgJHRoaXMtPmdldEluc3RhbGxFbWFpbFRlbXBsYXRlc0ZpbGUoKSwgTG9jYWxlOjp0cmFu c2xhdGUoJ2luc3RhbGxlci5pbnN0YWxsUGFyc2VFbWFpbFRlbXBsYXRlc0ZpbGVFcnJvcicpKSk7 CisJCQkJJHJlc3VsdCA9IGZhbHNlOworCQkJfQogCQl9CiAJCXJldHVybiBmYWxzZTsKIAl9Cg== 3517 2011-05-24 12:49:00 -0700 2011-05-24 13:37:04 -0700 Patch #2 against OJS 2.3.4 6658_2.diff text/plain 1054 michael.pkp LS0tIGEvY2xhc3Nlcy9wbHVnaW5zL1BLUFBsdWdpbi5pbmMucGhwCisrKyBiL2NsYXNzZXMvcGx1 Z2lucy9QS1BQbHVnaW4uaW5jLnBocApAQCAtNTQ0LDExICs1NDQsMTcgQEAgY2xhc3MgUEtQUGx1 Z2luIHsKIAogCQkkZW1haWxUZW1wbGF0ZURhbyA9JiBEQU9SZWdpc3RyeTo6Z2V0REFPKCdFbWFp bFRlbXBsYXRlREFPJyk7CiAJCSRzcWwgPSAkZW1haWxUZW1wbGF0ZURhby0+aW5zdGFsbEVtYWls VGVtcGxhdGVzKCR0aGlzLT5nZXRJbnN0YWxsRW1haWxUZW1wbGF0ZXNGaWxlKCksIHRydWUsIG51 bGwsIHRydWUpOwotCQlpZiAoJHNxbCkgewotCQkJJHJlc3VsdCA9ICRpbnN0YWxsZXItPmV4ZWN1 dGVTUUwoJHNxbCk7Ci0JCQlpZiAoISRyZXN1bHQpIHsKLQkJCQkkaW5zdGFsbGVyLT5zZXRFcnJv cihJTlNUQUxMRVJfRVJST1JfREIsIHN0cl9yZXBsYWNlKCd7JGZpbGV9JywgJHRoaXMtPmdldElu c3RhbGxFbWFpbFRlbXBsYXRlc0ZpbGUoKSwgTG9jYWxlOjp0cmFuc2xhdGUoJ2luc3RhbGxlci5p bnN0YWxsUGFyc2VFbWFpbFRlbXBsYXRlc0ZpbGVFcnJvcicpKSk7Ci0JCQkJJHJlc3VsdCA9IGZh bHNlOworCisJCWlmICgkc3FsID09PSBmYWxzZSkgeworCQkJLy8gVGhlIHRlbXBsYXRlIGZpbGUg c2VlbXMgdG8gYmUgaW52YWxpZC4KKwkJCSRpbnN0YWxsZXItPnNldEVycm9yKElOU1RBTExFUl9F UlJPUl9EQiwgc3RyX3JlcGxhY2UoJ3skZmlsZX0nLCAkdGhpcy0+Z2V0SW5zdGFsbERhdGFGaWxl KCksIExvY2FsZTo6dHJhbnNsYXRlKCdpbnN0YWxsZXIuaW5zdGFsbFBhcnNlRW1haWxUZW1wbGF0 ZXNGaWxlRXJyb3InKSkpOworCQkJJHJlc3VsdCA9IGZhbHNlOworCQl9IGVsc2UgeworCQkJLy8g QXJlIHRoZXJlIGFueSB5ZXQgdW5pbnN0YWxsZWQgZW1haWwgdGVtcGxhdGVzPworCQkJYXNzZXJ0 KGlzX2FycmF5KCRzcWwpKTsKKwkJCWlmICghZW1wdHkoJHNxbCkpIHsKKwkJCQkvLyBJbnN0YWxs IHRlbXBsYXRlcy4KKwkJCQkkcmVzdWx0ID0gJGluc3RhbGxlci0+ZXhlY3V0ZVNRTCgkc3FsKTsK IAkJCX0KIAkJfQogCQlyZXR1cm4gZmFsc2U7Cg== 3518 2011-05-24 13:37:00 -0700 2011-05-24 13:43:54 -0700 Patch against OJS 2.3.4 (needs to be applied against lib/pkp) 6658_3.diff text/plain 904 michael.pkp LS0tIGNsYXNzZXMvcGx1Z2lucy9QS1BQbHVnaW4ub2xkLmluYy5waHAJMjAxMS0wNS0yNCAxMzoz Mzo0My4wMDAwMDAwMDAgLTA3MDAKKysrIGNsYXNzZXMvcGx1Z2lucy9QS1BQbHVnaW4uaW5jLnBo cAkyMDExLTA1LTI0IDEyOjM1OjEzLjAwMDAwMDAwMCAtMDcwMApAQCAtNTQzLDExICs1NDQsMTgg QEAKIAogCQkkZW1haWxUZW1wbGF0ZURhbyA9JiBEQU9SZWdpc3RyeTo6Z2V0REFPKCdFbWFpbFRl bXBsYXRlREFPJyk7CiAJCSRzcWwgPSAkZW1haWxUZW1wbGF0ZURhby0+aW5zdGFsbEVtYWlsVGVt cGxhdGVzKCR0aGlzLT5nZXRJbnN0YWxsRW1haWxUZW1wbGF0ZXNGaWxlKCksIHRydWUsIG51bGws IHRydWUpOwotCQlpZiAoJHNxbCkgewotCQkJJHJlc3VsdCA9ICRpbnN0YWxsZXItPmV4ZWN1dGVT UUwoJHNxbCk7Ci0JCX0gZWxzZSB7CisKKwkJaWYgKCRzcWwgPT09IGZhbHNlKSB7CisJCQkvLyBU aGUgdGVtcGxhdGUgZmlsZSBzZWVtcyB0byBiZSBpbnZhbGlkLgogCQkJJGluc3RhbGxlci0+c2V0 RXJyb3IoSU5TVEFMTEVSX0VSUk9SX0RCLCBzdHJfcmVwbGFjZSgneyRmaWxlfScsICR0aGlzLT5n ZXRJbnN0YWxsRGF0YUZpbGUoKSwgTG9jYWxlOjp0cmFuc2xhdGUoJ2luc3RhbGxlci5pbnN0YWxs UGFyc2VFbWFpbFRlbXBsYXRlc0ZpbGVFcnJvcicpKSk7CiAJCQkkcmVzdWx0ID0gZmFsc2U7CisJ CX0gZWxzZSB7CisJCQkvLyBBcmUgdGhlcmUgYW55IHlldCB1bmluc3RhbGxlZCBlbWFpbCB0ZW1w bGF0ZXM/CisJCQlhc3NlcnQoaXNfYXJyYXkoJHNxbCkpOworCQkJaWYgKCFlbXB0eSgkc3FsKSkg eworCQkJCS8vIEluc3RhbGwgdGVtcGxhdGVzLgorCQkJCSRyZXN1bHQgPSAkaW5zdGFsbGVyLT5l eGVjdXRlU1FMKCRzcWwpOworCQkJfQogCQl9CiAJCXJldHVybiBmYWxzZTsKIAl9Cg==