6629 2011-05-02 12:18:00 -0700 Registration "Registered" date incorrectly updated 2011-05-03 12:31:09 -0700 1 1 1 Unclassified OCS Registrations 2.3.4 All All RESOLVED FIXED P3 normal --- 1 jmacgreg jmacgreg pkp-support 2.3.3 OCS 2.3.3 23693 3500 jmacgreg 2011-05-02 12:18:20 -0700 Created attachment 3500 patch against master If a user registers eg on 2011-01-01, and the Editor edits (or even views and saves without editing) their registration, the "Registered" date changes to the current date. I've modified wuyh's fix at http://pkp.sfu.ca/support/forum/viewtopic.php?f=3&t=2602&p=28892#p28892; see attached. I think it works fine, but I'd like someone to take a look. If it looks good, I'll commit to master and stable. 23707 michael.pkp 2011-05-03 10:26:39 -0700 Looks good, James. Can you please provide an updated patch against OCS 2.3.3-1 (stable) with the lib/pkp subcommit info removed + add to recommended patches list for OCS. Thanks! 23711 3503 jmacgreg 2011-05-03 12:30:31 -0700 Created attachment 3503 Patch against OCS 2.3.3-1 (stable) 23712 jmacgreg 2011-05-03 12:31:09 -0700 Thanks, Michael! Committed to stable and master, and added a patch here against 2.3.3-1. 3500 2011-05-02 12:18:00 -0700 2011-05-02 12:18:20 -0700 patch against master registration.diff text/plain 1256 jmacgreg ZGlmZiAtLWdpdCBhL2NsYXNzZXMvcmVnaXN0cmF0aW9uL2Zvcm0vUmVnaXN0cmF0aW9uRm9ybS5p bmMucGhwIGIvY2xhc3Nlcy9yZWdpc3RyYXRpb24vZm9ybS9SZWdpc3RyYXRpb25Gb3JtLmluYy5w aHAKaW5kZXggZDRkYzc5My4uNDFmOGQ0NCAxMDA3NTUKLS0tIGEvY2xhc3Nlcy9yZWdpc3RyYXRp b24vZm9ybS9SZWdpc3RyYXRpb25Gb3JtLmluYy5waHAKKysrIGIvY2xhc3Nlcy9yZWdpc3RyYXRp b24vZm9ybS9SZWdpc3RyYXRpb25Gb3JtLmluYy5waHAKQEAgLTE4MSw2ICsxODEsNyBAQCBjbGFz cyBSZWdpc3RyYXRpb25Gb3JtIGV4dGVuZHMgRm9ybSB7CiAKIAkJaWYgKCFpc3NldCgkcmVnaXN0 cmF0aW9uKSkgewogCQkJJHJlZ2lzdHJhdGlvbiA9IG5ldyBSZWdpc3RyYXRpb24oKTsKKwkJCSRy ZWdpc3RyYXRpb24tPnNldERhdGVSZWdpc3RlcmVkKHRpbWUoKSk7CiAJCX0KIAogCQkkcmVnaXN0 cmF0aW9uLT5zZXRTY2hlZENvbmZJZCgkc2NoZWRDb25mLT5nZXRJZCgpKTsKQEAgLTE5MCw3ICsx OTEsNiBAQCBjbGFzcyBSZWdpc3RyYXRpb25Gb3JtIGV4dGVuZHMgRm9ybSB7CiAJCSRyZWdpc3Ry YXRpb24tPnNldERvbWFpbigkdGhpcy0+Z2V0RGF0YSgnZG9tYWluJykgPyAkdGhpcy0+Z2V0RGF0 YSgnZG9tYWluJykgOiBudWxsKTsKIAkJJHJlZ2lzdHJhdGlvbi0+c2V0SVBSYW5nZSgkdGhpcy0+ Z2V0RGF0YSgnaXBSYW5nZScpID8gJHRoaXMtPmdldERhdGEoJ2lwUmFuZ2UnKSA6IG51bGwpOwog CQkkcmVnaXN0cmF0aW9uLT5zZXRTcGVjaWFsUmVxdWVzdHMoJHRoaXMtPmdldERhdGEoJ3NwZWNp YWxSZXF1ZXN0cycpID8gJHRoaXMtPmdldERhdGEoJ3NwZWNpYWxSZXF1ZXN0cycpIDogbnVsbCk7 Ci0JCSRyZWdpc3RyYXRpb24tPnNldERhdGVSZWdpc3RlcmVkKHRpbWUoKSk7CiAKIAkJLy8gU2Vu ZCBhbiBlbWFpbCB0byB0aGUgcmVnaXN0cmFudCBpbmZvcm1pbmcgdGhlbSB0aGF0IHRoZWlyIHBh eW1lbnQgd2FzIHJlY2VpdmVkCiAJCWlmICgkdGhpcy0+Z2V0RGF0YSgnbm90aWZ5UGF5bWVudEVt YWlsJykpIHsKZGlmZiAtLWdpdCBhL2xpYi9wa3AgYi9saWIvcGtwCmluZGV4IDkyNjQ5ODEuLmRh OGQ1NjcgMTYwMDAwCi0tLSBhL2xpYi9wa3AKKysrIGIvbGliL3BrcApAQCAtMSArMSBAQAotU3Vi cHJvamVjdCBjb21taXQgOTI2NDk4MTU1Y2RiZDhkYjkyMWU0Y2IxNDg3N2EyZWExNTA3MmM2OAor U3VicHJvamVjdCBjb21taXQgZGE4ZDU2NzYzZDAyNzM1ZjJjZDExYTU4NzRkODYzYmQzOWNjZjNm Zgo= 3503 2011-05-03 12:30:00 -0700 2011-05-03 12:30:31 -0700 Patch against OCS 2.3.3-1 (stable) 6629.diff text/plain 1035 jmacgreg ZGlmZiAtLWdpdCBhL2NsYXNzZXMvcmVnaXN0cmF0aW9uL2Zvcm0vUmVnaXN0cmF0aW9uRm9ybS5p bmMucGhwIGIvY2xhc3Nlcy9yZWdpc3RyYXRpb24vZm9ybS9SZWdpc3RyYXRpb25Gb3JtLmluYy5w aHAKaW5kZXggZDRkYzc5My4uNDFmOGQ0NCAxMDA3NTUKLS0tIGEvY2xhc3Nlcy9yZWdpc3RyYXRp b24vZm9ybS9SZWdpc3RyYXRpb25Gb3JtLmluYy5waHAKKysrIGIvY2xhc3Nlcy9yZWdpc3RyYXRp b24vZm9ybS9SZWdpc3RyYXRpb25Gb3JtLmluYy5waHAKQEAgLTE4MSw2ICsxODEsNyBAQCBjbGFz cyBSZWdpc3RyYXRpb25Gb3JtIGV4dGVuZHMgRm9ybSB7CiAKIAkJaWYgKCFpc3NldCgkcmVnaXN0 cmF0aW9uKSkgewogCQkJJHJlZ2lzdHJhdGlvbiA9IG5ldyBSZWdpc3RyYXRpb24oKTsKKwkJCSRy ZWdpc3RyYXRpb24tPnNldERhdGVSZWdpc3RlcmVkKHRpbWUoKSk7CiAJCX0KIAogCQkkcmVnaXN0 cmF0aW9uLT5zZXRTY2hlZENvbmZJZCgkc2NoZWRDb25mLT5nZXRJZCgpKTsKQEAgLTE5MCw3ICsx OTEsNiBAQCBjbGFzcyBSZWdpc3RyYXRpb25Gb3JtIGV4dGVuZHMgRm9ybSB7CiAJCSRyZWdpc3Ry YXRpb24tPnNldERvbWFpbigkdGhpcy0+Z2V0RGF0YSgnZG9tYWluJykgPyAkdGhpcy0+Z2V0RGF0 YSgnZG9tYWluJykgOiBudWxsKTsKIAkJJHJlZ2lzdHJhdGlvbi0+c2V0SVBSYW5nZSgkdGhpcy0+ Z2V0RGF0YSgnaXBSYW5nZScpID8gJHRoaXMtPmdldERhdGEoJ2lwUmFuZ2UnKSA6IG51bGwpOwog CQkkcmVnaXN0cmF0aW9uLT5zZXRTcGVjaWFsUmVxdWVzdHMoJHRoaXMtPmdldERhdGEoJ3NwZWNp YWxSZXF1ZXN0cycpID8gJHRoaXMtPmdldERhdGEoJ3NwZWNpYWxSZXF1ZXN0cycpIDogbnVsbCk7 Ci0JCSRyZWdpc3RyYXRpb24tPnNldERhdGVSZWdpc3RlcmVkKHRpbWUoKSk7CiAKIAkJLy8gU2Vu ZCBhbiBlbWFpbCB0byB0aGUgcmVnaXN0cmFudCBpbmZvcm1pbmcgdGhlbSB0aGF0IHRoZWlyIHBh eW1lbnQgd2FzIHJlY2VpdmVkCiAJCWlmICgkdGhpcy0+Z2V0RGF0YSgnbm90aWZ5UGF5bWVudEVt YWlsJykpIHsK