6596 2011-04-14 11:07:00 -0700 Undefined schedConfId variable in PayPalPlugin 2011-04-14 11:18:58 -0700 1 1 1 Unclassified OCS General To be determined All All RESOLVED FIXED P3 normal --- 1 mattcrider pkp-support 23571 mattcrider 2011-04-14 11:07:52 -0700 Lines 236-240 of plugins/paymethod/paypal/PayPalPlugin.inc.php refer to a $schedConfId variable that is not defined anywhere. 23572 3481 mattcrider 2011-04-14 11:15:55 -0700 Created attachment 3481 Patch against OCS pre-2.3.3.2 23573 mattcrider 2011-04-14 11:16:02 -0700 Fixed. https://github.com/pkp/ocs/commit/c981dc26180acbd77963adfa86b4d41fe856060e https://github.com/pkp/ocs/commit/11d87ba0570e48900a806c1c6a3918685bb0225c (stable) 3481 2011-04-14 11:15:00 -0700 2011-04-14 11:15:55 -0700 Patch against OCS pre-2.3.3.2 6596.patch text/plain 4073 mattcrider ZGlmZiAtLWdpdCBhL3BsdWdpbnMvcGF5bWV0aG9kL3BheXBhbC9QYXlQYWxQbHVnaW4uaW5jLnBo cCBiL3BsdWdpbnMvcGF5bWV0aG9kL3BheXBhbC9QYXlQYWxQbHVnaW4uaW5jLnBocAppbmRleCAw MTMzODI1Li41Y2U1ZjNiIDEwMDY0NAotLS0gYS9wbHVnaW5zL3BheW1ldGhvZC9wYXlwYWwvUGF5 UGFsUGx1Z2luLmluYy5waHAKKysrIGIvcGx1Z2lucy9wYXltZXRob2QvcGF5cGFsL1BheVBhbFBs dWdpbi5pbmMucGhwCkBAIC0yOCwxMCArMjgsMTAgQEAgY2xhc3MgUGF5UGFsUGx1Z2luIGV4dGVu ZHMgUGF5bWV0aG9kUGx1Z2luIHsKIAogCWZ1bmN0aW9uIGdldERlc2NyaXB0aW9uKCkgewogCQly ZXR1cm4gTG9jYWxlOjp0cmFuc2xhdGUoJ3BsdWdpbnMucGF5bWV0aG9kLnBheXBhbC5kZXNjcmlw dGlvbicpOwotCX0gICAKKwl9CiAKIAlmdW5jdGlvbiByZWdpc3RlcigkY2F0ZWdvcnksICRwYXRo KSB7Ci0JCWlmIChwYXJlbnQ6OnJlZ2lzdGVyKCRjYXRlZ29yeSwgJHBhdGgpKSB7CQkJCisJCWlm IChwYXJlbnQ6OnJlZ2lzdGVyKCRjYXRlZ29yeSwgJHBhdGgpKSB7CiAJCQkkdGhpcy0+YWRkTG9j YWxlRGF0YSgpOwogCQkJJHRoaXMtPmltcG9ydCgnUGF5UGFsREFPJyk7CiAJCQkkcGF5UGFsRGFv ID0gbmV3IFBheVBhbERBTygpOwpAQCAtODIsMTIgKzgyLDEyIEBAIGNsYXNzIFBheVBhbFBsdWdp biBleHRlbmRzIFBheW1ldGhvZFBsdWdpbiB7CiAJCQknbm9fbm90ZScgPT4gMSwKIAkJCSdub19z aGlwcGluZycgPT4gMSwKIAkJCSdjdXJyZW5jeV9jb2RlJyA9PiAkcXVldWVkUGF5bWVudC0+Z2V0 Q3VycmVuY3lDb2RlKCksCi0JCQknbGMnID0+IFN0cmluZzo6c3Vic3RyKExvY2FsZTo6Z2V0TG9j YWxlKCksIDMpLCAKKwkJCSdsYycgPT4gU3RyaW5nOjpzdWJzdHIoTG9jYWxlOjpnZXRMb2NhbGUo KSwgMyksCiAJCQknY3VzdG9tJyA9PiAkcXVldWVkUGF5bWVudElkLAotCQkJJ25vdGlmeV91cmwn ID0+IFJlcXVlc3Q6OnVybChudWxsLCBudWxsLCAncGF5bWVudCcsICdwbHVnaW4nLCBhcnJheSgk dGhpcy0+Z2V0TmFtZSgpLCAnaXBuJykpLCAgCisJCQknbm90aWZ5X3VybCcgPT4gUmVxdWVzdDo6 dXJsKG51bGwsIG51bGwsICdwYXltZW50JywgJ3BsdWdpbicsIGFycmF5KCR0aGlzLT5nZXROYW1l KCksICdpcG4nKSksCiAJCQkncmV0dXJuJyA9PiAkcXVldWVkUGF5bWVudC0+Z2V0UmVxdWVzdFVy bCgpLAogCQkJJ2NhbmNlbF9yZXR1cm4nID0+IFJlcXVlc3Q6OnVybChudWxsLCBudWxsLCAncGF5 bWVudCcsICdwbHVnaW4nLCBhcnJheSgkdGhpcy0+Z2V0TmFtZSgpLCAnY2FuY2VsJykpLAotCQkJ J2ZpcnN0X25hbWUnID0+ICgkdXNlcik/JHVzZXItPmdldEZpcnN0TmFtZSgpOicnLCAgCisJCQkn Zmlyc3RfbmFtZScgPT4gKCR1c2VyKT8kdXNlci0+Z2V0Rmlyc3ROYW1lKCk6JycsCiAJCQknbGFz dF9uYW1lJyA9PiAoJHVzZXIpPyR1c2VyLT5nZXRMYXN0bmFtZSgpOicnLAogCQkJJ2l0ZW1fbnVt YmVyJyA9PiAxLAogCQkJJ2NtZCcgPT4gJ194Y2xpY2snCkBAIC0xMjQsNyArMTI0LDcgQEAgY2xh c3MgUGF5UGFsUGx1Z2luIGV4dGVuZHMgUGF5bWV0aG9kUGx1Z2luIHsKIAkJCQlpZiAoZ2V0X21h Z2ljX3F1b3Rlc19ncGMoKSkgewogCQkJCQlmb3JlYWNoICgkX1BPU1QgYXMgJGtleSA9PiAkdmFs dWUpICRyZXEgLj0gJyYnIC4gdXJsZW5jb2RlKHN0cmlwc2xhc2hlcygka2V5KSkgLiAnPScgLiB1 cmxlbmNvZGUoc3RyaXBzbGFzaGVzKCR2YWx1ZSkpOwogCQkJCX0gZWxzZSB7Ci0JCQkJCWZvcmVh Y2ggKCRfUE9TVCBhcyAka2V5ID0+ICR2YWx1ZSkgJHJlcSAuPSAnJicgLiB1cmxlbmNvZGUoJGtl eSkgLiAnPScgLiB1cmxlbmNvZGUoJHZhbHVlKTsJCisJCQkJCWZvcmVhY2ggKCRfUE9TVCBhcyAk a2V5ID0+ICR2YWx1ZSkgJHJlcSAuPSAnJicgLiB1cmxlbmNvZGUoJGtleSkgLiAnPScgLiB1cmxl bmNvZGUoJHZhbHVlKTsKIAkJCQl9CiAKIAkJCQkvLyBDcmVhdGUgUE9TVCByZXNwb25zZQpAQCAt MjA5LDMzICsyMDksMzQgQEAgY2xhc3MgUGF5UGFsUGx1Z2luIGV4dGVuZHMgUGF5bWV0aG9kUGx1 Z2luIHsKIAkJCQkJCQlpZiAoJG9jc1BheW1lbnRNYW5hZ2VyLT5mdWxmaWxsUXVldWVkUGF5bWVu dCgkcXVldWVkUGF5bWVudElkLCAkcXVldWVkUGF5bWVudCkpIHsKIAkJCQkJCQkJLy8gU2VuZCB0 aGUgcmVnaXN0cmFudCBhIG5vdGlmaWNhdGlvbiB0aGF0IHRoZWlyIHBheW1lbnQgd2FzIHJlY2Vp dmVkCiAJCQkJCQkJCSRzY2hlZENvbmZTZXR0aW5nc0RhbyA9JiBEQU9SZWdpc3RyeTo6Z2V0REFP KCdTY2hlZENvbmZTZXR0aW5nc0RBTycpOwotCQkKKworCQkJCQkJCQkkc2NoZWRDb25mSWQgPSAk c2NoZWRDb25mLT5nZXRJZCgpOwogCQkJCQkJCQkkcmVnaXN0cmF0aW9uTmFtZSA9ICRzY2hlZENv bmZTZXR0aW5nc0Rhby0+Z2V0U2V0dGluZygkc2NoZWRDb25mSWQsICdyZWdpc3RyYXRpb25OYW1l Jyk7CiAJCQkJCQkJCSRyZWdpc3RyYXRpb25FbWFpbCA9ICRzY2hlZENvbmZTZXR0aW5nc0Rhby0+ Z2V0U2V0dGluZygkc2NoZWRDb25mSWQsICdyZWdpc3RyYXRpb25FbWFpbCcpOwogCQkJCQkJCQkk cmVnaXN0cmF0aW9uUGhvbmUgPSAkc2NoZWRDb25mU2V0dGluZ3NEYW8tPmdldFNldHRpbmcoJHNj aGVkQ29uZklkLCAncmVnaXN0cmF0aW9uUGhvbmUnKTsKIAkJCQkJCQkJJHJlZ2lzdHJhdGlvbkZh eCA9ICRzY2hlZENvbmZTZXR0aW5nc0Rhby0+Z2V0U2V0dGluZygkc2NoZWRDb25mSWQsICdyZWdp c3RyYXRpb25GYXgnKTsKIAkJCQkJCQkJJHJlZ2lzdHJhdGlvbk1haWxpbmdBZGRyZXNzID0gJHNj aGVkQ29uZlNldHRpbmdzRGFvLT5nZXRTZXR0aW5nKCRzY2hlZENvbmZJZCwgJ3JlZ2lzdHJhdGlv bk1haWxpbmdBZGRyZXNzJyk7CiAJCQkJCQkJCSRyZWdpc3RyYXRpb25Db250YWN0U2lnbmF0dXJl ID0gJHJlZ2lzdHJhdGlvbk5hbWU7Ci0JCQkJCQkKKwogCQkJCQkJCQlpZiAoJHJlZ2lzdHJhdGlv bk1haWxpbmdBZGRyZXNzICE9ICcnKSAkcmVnaXN0cmF0aW9uQ29udGFjdFNpZ25hdHVyZSAuPSAi XG4iIC4gJHJlZ2lzdHJhdGlvbk1haWxpbmdBZGRyZXNzOwogCQkJCQkJCQlpZiAoJHJlZ2lzdHJh dGlvblBob25lICE9ICcnKSAkcmVnaXN0cmF0aW9uQ29udGFjdFNpZ25hdHVyZSAuPSAiXG4iIC4g TG9jYWxlOjpUcmFuc2xhdGUoJ3VzZXIucGhvbmUnKSAuICc6ICcgLiAkcmVnaXN0cmF0aW9uUGhv bmU7CiAJCQkJCQkJCWlmICgkcmVnaXN0cmF0aW9uRmF4ICE9ICcnKQkkcmVnaXN0cmF0aW9uQ29u dGFjdFNpZ25hdHVyZSAuPSAiXG4iIC4gTG9jYWxlOjpUcmFuc2xhdGUoJ3VzZXIuZmF4JykgLiAn OiAnIC4gJHJlZ2lzdHJhdGlvbkZheDsKLQkJCQkJCQorCiAJCQkJCQkJCSRyZWdpc3RyYXRpb25D b250YWN0U2lnbmF0dXJlIC49ICJcbiIgLiBMb2NhbGU6OlRyYW5zbGF0ZSgndXNlci5lbWFpbCcp IC4gJzogJyAuICRyZWdpc3RyYXRpb25FbWFpbDsKIAogCQkJCQkJCQkkcGFyYW1BcnJheSA9IGFy cmF5KAogCQkJCQkJCQkJJ3JlZ2lzdHJhbnROYW1lJyA9PiAkY29udGFjdE5hbWUsCiAJCQkJCQkJ CQknc2NoZWRDb25mTmFtZScgPT4gJHNjaGVkQ29uZk5hbWUsCi0JCQkJCQkJCQkncmVnaXN0cmF0 aW9uQ29udGFjdFNpZ25hdHVyZScgPT4gJHJlZ2lzdHJhdGlvbkNvbnRhY3RTaWduYXR1cmUgCisJ CQkJCQkJCQkncmVnaXN0cmF0aW9uQ29udGFjdFNpZ25hdHVyZScgPT4gJHJlZ2lzdHJhdGlvbkNv bnRhY3RTaWduYXR1cmUKIAkJCQkJCQkJKTsKLQkJCQkJCQorCiAJCQkJCQkJCWltcG9ydCgnbWFp bC5NYWlsVGVtcGxhdGUnKTsKIAkJCQkJCQkJJG1haWwgPSBuZXcgTWFpbFRlbXBsYXRlKCdNQU5V QUxfUEFZTUVOVF9SRUNFSVZFRCcpOwogCQkJCQkJCQkkbWFpbC0+c2V0RnJvbSgkcmVnaXN0cmF0 aW9uRW1haWwsICRyZWdpc3RyYXRpb25OYW1lKTsKIAkJCQkJCQkJJG1haWwtPmFzc2lnblBhcmFt cygkcGFyYW1BcnJheSk7CiAJCQkJCQkJCSRtYWlsLT5hZGRSZWNpcGllbnQoJGNvbnRhY3RFbWFp bCwgJGNvbnRhY3ROYW1lKTsKIAkJCQkJCQkJJG1haWwtPnNlbmQoKTsKLQkJCQkJCQkJCisKIAkJ CQkJCQkJZXhpdCgpOwogCQkJCQkJCX0KIAo=