<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "http://pkp.sfu.ca/bugzilla/bugzilla.dtd">

<bugzilla version="4.2.5+"
          urlbase="http://pkp.sfu.ca/bugzilla/"
          
          maintainer="pkp-hosted@sfu.ca"
>

    <bug>
          <bug_id>6409</bug_id>
          
          <creation_ts>2011-02-14 16:36:00 -0800</creation_ts>
          <short_desc>PromoteForm and NewReviewRound form need the reviewType</short_desc>
          <delta_ts>2011-07-10 14:37:55 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>OMP</product>
          <component>General</component>
          <version>1.0</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>INVALID</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P3</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>6410</blocked>
          <everconfirmed>1</everconfirmed>
          <reporter name="jerico">jerico.dev</reporter>
          <assigned_to name="PKP Support">pkp-support</assigned_to>
          <cc>juan</cc>
          
          

      

      

      

          <long_desc isprivate="0">
            <commentid>22859</commentid>
            <who name="jerico">jerico.dev</who>
            <bug_when>2011-02-14 16:36:53 -0800</bug_when>
            <thetext>The grids in promoteForm.tpl and newReviewRound.tpl rely on reviewType to retrieve their data. I&apos;d removed that based on the assumption that #6129 would remove review type altogether and only rely on review round + workflow stage. Now it&apos;s the other way round, so we either need to base everything off workflow stages or we need to consistently maintain review rounds everywhere.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>24314</commentid>
            <who name="Juan Pablo Alperin">juan</who>
            <bug_when>2011-07-10 14:37:55 -0700</bug_when>
            <thetext>that assumption is correct. It will be based on stageId and round.</thetext>
          </long_desc>
      
      

    </bug>

</bugzilla>