6248 2010-11-25 12:20:00 -0800 Paper commenting "add" form broken 2011-08-11 11:00:02 -0700 1 1 1 Unclassified OCS General 2.3.4 All All RESOLVED FIXED P3 normal --- 1 alec pkp-support kritikes.spoudes 22289 alec 2010-11-25 12:20:35 -0800 See http://pkp.sfu.ca/support/forum/viewtopic.php?f=3&t=6874&p=26606#p26606 22290 3353 alec 2010-11-25 12:21:51 -0800 Created attachment 3353 Patch against PKP pre-release 22291 3354 alec 2010-11-25 12:22:14 -0800 Created attachment 3354 Patch against OCS pre-2.3.4 22292 alec 2010-11-25 12:22:32 -0800 Fixed. 22419 3386 alec 2010-12-06 16:18:37 -0800 Created attachment 3386 Patch against OCS 2.3.3-1 OCS 2.3.3-1 users will need to apply both the PKP and OCS 2.3.3-1 parts of the patch. 24818 michael.pkp 2011-08-11 11:00:02 -0700 Paper commenting "add" form broken https://github.com/pkp/ocs/commit/9527e4e11b5c504bf24c8204729d03e188e64122 3353 2010-11-25 12:21:00 -0800 2010-11-25 12:21:51 -0800 Patch against PKP pre-release 6248-p.diff text/plain 819 alec ZGlmZiAtLWdpdCBhL2NsYXNzZXMvY29tbWVudC9Db21tZW50REFPLmluYy5waHAgYi9jbGFzc2Vz L2NvbW1lbnQvQ29tbWVudERBTy5pbmMucGhwCmluZGV4IDZlYzkyYjkuLmQ0ZTczMzcgMTAwNjQ0 Ci0tLSBhL2NsYXNzZXMvY29tbWVudC9Db21tZW50REFPLmluYy5waHAKKysrIGIvY2xhc3Nlcy9j b21tZW50L0NvbW1lbnREQU8uaW5jLnBocApAQCAtMTU4LDcgKzE1OCw3IEBAIGNsYXNzIENvbW1l bnREQU8gZXh0ZW5kcyBEQU8gewogCiAJCWlmICghSG9va1JlZ2lzdHJ5OjpjYWxsKCdDb21tZW50 REFPOjpfcmV0dXJuQ29tbWVudEZyb21Sb3cnLCBhcnJheSgmJGNvbW1lbnQsICYkcm93LCAmJGNo aWxkTGV2ZWxzKSkpIHsKIAkJCWlmICgkY2hpbGRMZXZlbHM+MCkgJGNvbW1lbnQtPnNldENoaWxk cmVuKCR0aGlzLT5nZXRDb21tZW50c0J5UGFyZW50SWQoJHJvd1snY29tbWVudF9pZCddLCAkY2hp bGRMZXZlbHMtMSkpOwotCQkJZWxzZSBpZiAoJGNoaWxkTGV2ZWxzPT1BUlRJQ0xFX0NPTU1FTlRf UkVDVVJTRV9BTEwpICRjb21tZW50LT5zZXRDaGlsZHJlbigkdGhpcy0+Z2V0Q29tbWVudHNCeVBh cmVudElkKCRyb3dbJ2NvbW1lbnRfaWQnXSwgQVJUSUNMRV9DT01NRU5UX1JFQ1VSU0VfQUxMKSk7 CisJCQllbHNlIGlmICgkY2hpbGRMZXZlbHM9PVNVQk1JU1NJT05fQ09NTUVOVF9SRUNVUlNFX0FM TCkgJGNvbW1lbnQtPnNldENoaWxkcmVuKCR0aGlzLT5nZXRDb21tZW50c0J5UGFyZW50SWQoJHJv d1snY29tbWVudF9pZCddLCBTVUJNSVNTSU9OX0NPTU1FTlRfUkVDVVJTRV9BTEwpKTsKIAkJfQog CiAJCXJldHVybiAkY29tbWVudDsK 3354 2010-11-25 12:22:00 -0800 2010-11-25 12:22:14 -0800 Patch against OCS pre-2.3.4 6248-o.diff text/plain 612 alec ZGlmZiAtLWdpdCBhL3BhZ2VzL2NvbW1lbnQvQ29tbWVudEhhbmRsZXIuaW5jLnBocCBiL3BhZ2Vz L2NvbW1lbnQvQ29tbWVudEhhbmRsZXIuaW5jLnBocAppbmRleCAxN2E5YWE1Li5lODQzNGMyIDEw MDY0NAotLS0gYS9wYWdlcy9jb21tZW50L0NvbW1lbnRIYW5kbGVyLmluYy5waHAKKysrIGIvcGFn ZXMvY29tbWVudC9Db21tZW50SGFuZGxlci5pbmMucGhwCkBAIC05MCw3ICs5MCw3IEBAIGNsYXNz IENvbW1lbnRIYW5kbGVyIGV4dGVuZHMgSGFuZGxlciB7CiAJCSRzY2hlZENvbmYgPSYgUmVxdWVz dDo6Z2V0U2NoZWRDb25mKCk7CiAJCSR0aGlzLT52YWxpZGF0ZSgkcGFwZXJJZCk7CiAJCSRwYXBl ciA9JiAkdGhpcy0+cGFwZXI7Ci0KKwkJJGNvbW1lbnREYW8gPSYgREFPUmVnaXN0cnk6OmdldERB TygnQ29tbWVudERBTycpOwogCQkkcGFyZW50ID0mICRjb21tZW50RGFvLT5nZXRCeUlkKCRwYXJl bnRJZCwgJHBhcGVySWQpOwogCQlpZiAoaXNzZXQoJHBhcmVudCkgJiYgJHBhcmVudC0+Z2V0UGFw ZXJJZCgpICE9ICRwYXBlcklkKSB7CiAJCQlSZXF1ZXN0OjpyZWRpcmVjdChudWxsLCBudWxsLCBu dWxsLCAndmlldycsIGFycmF5KCRwYXBlcklkLCAkZ2FsbGV5SWQpKTsK 3386 2010-12-06 16:18:00 -0800 2010-12-06 16:18:37 -0800 Patch against OCS 2.3.3-1 6248.diff text/plain 483 alec LS0tIHBhZ2VzL2NvbW1lbnQvQ29tbWVudEhhbmRsZXIuaW5jLnBocAkyMDEwLTEyLTA2IDE1OjQ4 OjAxLjAwMDAwMDAwMCAtMDgwMAorKysgcGFnZXMvY29tbWVudC9Db21tZW50SGFuZGxlci5pbmMu cGhwCTIwMTAtMTItMDYgMTU6NDg6MjguMDAwMDAwMDAwIC0wODAwCkBAIC05MSw2ICs5MSw3IEBA CiAJCSR0aGlzLT52YWxpZGF0ZSgkcGFwZXJJZCk7CiAJCSRwYXBlciA9JiAkdGhpcy0+cGFwZXI7 CiAKKwkJJGNvbW1lbnREYW8gPSYgREFPUmVnaXN0cnk6OmdldERBTygnQ29tbWVudERBTycpOwog CQkkcGFyZW50ID0mICRjb21tZW50RGFvLT5nZXRDb21tZW50KCRwYXJlbnRJZCwgJHBhcGVySWQp OwogCQlpZiAoaXNzZXQoJHBhcmVudCkgJiYgJHBhcmVudC0+Z2V0UGFwZXJJZCgpICE9ICRwYXBl cklkKSB7CiAJCQlSZXF1ZXN0OjpyZWRpcmVjdChudWxsLCBudWxsLCBudWxsLCAndmlldycsIGFy cmF5KCRwYXBlcklkLCAkZ2FsbGV5SWQpKTsK