<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "http://pkp.sfu.ca/bugzilla/bugzilla.dtd">

<bugzilla version="4.2.5+"
          urlbase="http://pkp.sfu.ca/bugzilla/"
          
          maintainer="pkp-hosted@sfu.ca"
>

    <bug>
          <bug_id>5505</bug_id>
          
          <creation_ts>2010-06-16 11:07:00 -0700</creation_ts>
          <short_desc>GenericPlugin.inc.php load error</short_desc>
          <delta_ts>2010-06-24 15:45:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>OJS</product>
          <component>Plug-ins</component>
          <version>2.3.3</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Mac OS X 10.4</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P5</priority>
          <bug_severity>normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="James MacGregor">jmacgreg</reporter>
          <assigned_to name="jerico">jerico.dev</assigned_to>
          <cc>jerico.dev</cc>
    
    <cc>pkp-support</cc>
          <cf_reportedversion>2.3.2</cf_reportedversion>
          

      

      

      

          <long_desc isprivate="0">
            <commentid>19745</commentid>
            <who name="James MacGregor">jmacgreg</who>
            <bug_when>2010-06-16 11:07:58 -0700</bug_when>
            <thetext>I&apos;m seeing the following error while trying to load pages within OJS (I&apos;m guessing it&apos;s part of the ongoing plugin restructuring to PKP WAL, but I figure I&apos;d report it anyway): 

[Wed Jun 16 11:07:16 2010] [error] [client 127.0.0.1] ojs2 has produced an error\n  Message: WARNING: include_once(/Users/jmacgreg/git/ojs/classes/plugins/GenericPlugin.inc.php): failed to open stream: No such file or directory\n  In file: /Users/jmacgreg/git/ojs/lib/pkp/includes/functions.inc.php\n  At line: 30\n  Stacktrace: \n  Server info:\n   OS: Darwin\n   PHP Version: 5.3.1\n   Apache Version: Apache/2.2.14 (Unix) mod_ssl/2.2.14 OpenSSL/0.9.8l DAV/2 PHP/5.3.1 mod_fastcgi/2.4.2\n   DB Driver: mysql\n   DB server version: 5.1.38, referer: http://git/ojs/index.php/index/user
[Wed Jun 16 11:07:16 2010] [error] [client 127.0.0.1] ojs2 has produced an error\n  Message: WARNING: include_once(): Failed opening &apos;/Users/jmacgreg/git/ojs/classes/plugins/GenericPlugin.inc.php&apos; for inclusion (include_path=&apos;.:/Users/jmacgreg/git/ojs/classes:/Users/jmacgreg/git/ojs/pages:/Users/jmacgreg/git/ojs/lib/pkp:/Users/jmacgreg/git/ojs/lib/pkp/classes:/Users/jmacgreg/git/ojs/lib/pkp/pages:/Users/jmacgreg/git/ojs/lib/pkp/lib/adodb:/Users/jmacgreg/git/ojs/lib/pkp/lib/phputf8:/Users/jmacgreg/git/ojs/lib/pkp/lib/pqp/classes:/Users/jmacgreg/git/ojs/lib/pkp/lib/smarty:.:/usr/lib/php&apos;)\n  In file: /Users/jmacgreg/git/ojs/lib/pkp/includes/functions.inc.php\n  At line: 30\n  Stacktrace: \n  Server info:\n   OS: Darwin\n   PHP Version: 5.3.1\n   Apache Version: Apache/2.2.14 (Unix) mod_ssl/2.2.14 OpenSSL/0.9.8l DAV/2 PHP/5.3.1 mod_fastcgi/2.4.2\n   DB Driver: mysql\n   DB server version: 5.1.38, referer: http://git/ojs/index.php/index/user</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>19750</commentid>
            <who name="jerico">jerico.dev</who>
            <bug_when>2010-06-16 22:34:34 -0700</bug_when>
            <thetext>Hi James,

this looks like an outdated include path. What exactly is the URL you&apos;re trying to open? I couldn&apos;t reproduce the problem with arbitrary URLs.

Florian</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>19752</commentid>
            <who name="James MacGregor">jmacgreg</who>
            <bug_when>2010-06-16 22:53:13 -0700</bug_when>
            <thetext>(In reply to comment #1)
&gt; Hi James,
&gt; 
&gt; this looks like an outdated include path. What exactly is the URL you&apos;re trying
&gt; to open? I couldn&apos;t reproduce the problem with arbitrary URLs.
&gt; 
&gt; Florian

Hi Florian, 

It happens no matter which page I load. I&apos;m pretty confident that my install (both ojs and lib/pkp) is up-to-date, and I&apos;m on master, but I don&apos;t mind doing a fresh checkout if you think I might&apos;ve messed something up.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>19753</commentid>
            <who name="James MacGregor">jmacgreg</who>
            <bug_when>2010-06-16 22:58:07 -0700</bug_when>
            <thetext>Wait, nevermind -- I figured it out. I had an old, external plugin installed (the latexRender plugin from the plugin galley), which of course hasn&apos;t been updated like the other included plugins, and so it was trying to call the old genericPlugin.inc.php file. If this will break old, non-included plugins, we&apos;ll probably want to include a notice of such in the release notes, and maybe post something to the forum.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>19759</commentid>
            <who name="jerico">jerico.dev</who>
            <bug_when>2010-06-18 03:56:35 -0700</bug_when>
            <thetext>Hi James, no, that&apos;s a problem. All plug-in changes should be backwards compatible. No legacy/community plug-in should break due to my plug-in changes. That&apos;s a very important requirement. It&apos;s nice that you came across this bug before our users hit it. I&apos;ll have a look at the latexRender plugin and leave this issue assigned to me. I&apos;m onto something else currently.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>19823</commentid>
            <who name="jerico">jerico.dev</who>
            <bug_when>2010-06-24 15:36:46 -0700</bug_when>
            <thetext>Hi James,

this was really a bug that had to do with the &quot;absolute include path&quot; change. The fix is here: http://github.com/pkp/pkp-lib/commit/029624a7f2c5f3dd5e50929f10556f9275d9720c

Did this fix the issue?</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>19824</commentid>
            <who name="James MacGregor">jmacgreg</who>
            <bug_when>2010-06-24 15:45:16 -0700</bug_when>
            <thetext>(In reply to comment #5)
&gt; Hi James,
&gt; 
&gt; this was really a bug that had to do with the &quot;absolute include path&quot; change.
&gt; The fix is here:
&gt; http://github.com/pkp/pkp-lib/commit/029624a7f2c5f3dd5e50929f10556f9275d9720c
&gt; 
&gt; Did this fix the issue?

Yep, that did the trick and everything looks great now -- thanks, Florian!</thetext>
          </long_desc>
      
      

    </bug>

</bugzilla>