5324 2010-04-19 10:54:00 -0700 Registration closes before end of day on the closing date 2012-03-15 09:46:46 -0700 1 1 1 Unclassified OCS General 2.3.5 PC Mac OS X 10.3 RESOLVED FIXED P5 normal --- 1 jmacgreg pkp-support alec michael.pkp 2.3.0 19182 jmacgreg 2010-04-19 10:54:37 -0700 Conference Timeline "Close" dates should be standardized to end-of-day, and this should be made explicit on the Timeline page, probably in the instructions at the top of page. Currently, the Abstract close date is set to close at 23:59:59 of the day specified in the timeline (see Bug 3369); however, other close dates appear to close at 00:00:00 of the day specified. I think that all close dates should be set to 23:59:59, as it is for abstract submission, even if it is confusing for conferences already using the system -- overly permissive is probably better than unexpectedly strict in this case (although I'm happy to to hear objections to this). Information explicitly stating close times should also be added to the top of the page. Something like: "All close times are set to happen at the end of the selected day." (Courtesy of http://pkp.sfu.ca/support/forum/viewtopic.php?f=3&t=6008&p=22957#p22957) 25444 3644 michael.pkp 2011-09-19 12:57:26 -0700 Created attachment 3644 Patch against OCS pre-2.3.4 25445 michael.pkp 2011-09-19 13:00:03 -0700 Registration closes before end of day on the closing date https://github.com/pkp/ocs/commit/fbad3b572c0127f678d24ee36259a26bcdb8fea7 25446 michael.pkp 2011-09-19 13:20:15 -0700 Thanks, James. Looking at this in more detail, a) conference timeline closing dates are being saved correctly in the db (with a time of 23:59:59). b) registration type closing date was saved correctly in the db, but incorrectly retrieved via the DAO (missing time component). c) registration option closing date was incorrectly being saved in the db as date only (no time component). For new installations, all close dates should now be saved and retrieved correctly. 25447 michael.pkp 2011-09-19 13:34:28 -0700 Existing installations that have not been upgraded to at least OCS 2.3.4 will need to be manually updated in order to modify the registration options closing date column: ALTER TABLE registration_options CHANGE COLUMN closing_date closing_date DATETIME NOT NULL; 25448 michael.pkp 2011-09-19 13:42:40 -0700 For all scheduled conferences created using a version of OCS older that OCS 2.3.4, the time component for registration option closing dates will be 00:00:00. This can be updated to 23:59:59 by editing/re-saving all relevant registration options via the standard OCS conference manager pages. The times will not be updated automatically by the OCS 2.3.4 upgrade script to ensure that conferences that expect the old behaviour (i.e. registration closing one day sooner) can decide whether the times should be updated. 25449 michael.pkp 2011-09-19 14:05:02 -0700 Registration closes before end of day on the closing date https://github.com/pkp/ocs/commit/645122f2071ab099baf074e23bd3c1422830220b 25450 michael.pkp 2011-09-19 14:08:56 -0700 Fixed. 3644 2011-09-19 12:57:00 -0700 2011-09-19 12:57:26 -0700 Patch against OCS pre-2.3.4 5324.diff text/plain 2474 michael.pkp LS0tIGEvY2xhc3Nlcy9yZWdpc3RyYXRpb24vUmVnaXN0cmF0aW9uT3B0aW9uREFPLmluYy5waHAK KysrIGIvY2xhc3Nlcy9yZWdpc3RyYXRpb24vUmVnaXN0cmF0aW9uT3B0aW9uREFPLmluYy5waHAK QEAgLTE3OCw3ICsxNzgsNyBAQCBjbGFzcyBSZWdpc3RyYXRpb25PcHRpb25EQU8gZXh0ZW5kcyBE QU8gewogCQkkcmVnaXN0cmF0aW9uT3B0aW9uLT5zZXRTY2hlZENvbmZJZCgkcm93WydzY2hlZF9j b25mX2lkJ10pOwogCQkkcmVnaXN0cmF0aW9uT3B0aW9uLT5zZXRDb2RlKCRyb3dbJ2NvZGUnXSk7 CiAJCSRyZWdpc3RyYXRpb25PcHRpb24tPnNldE9wZW5pbmdEYXRlKCR0aGlzLT5kYXRlRnJvbURC KCRyb3dbJ29wZW5pbmdfZGF0ZSddKSk7Ci0JCSRyZWdpc3RyYXRpb25PcHRpb24tPnNldENsb3Np bmdEYXRlKCR0aGlzLT5kYXRlRnJvbURCKCRyb3dbJ2Nsb3NpbmdfZGF0ZSddKSk7CisJCSRyZWdp c3RyYXRpb25PcHRpb24tPnNldENsb3NpbmdEYXRlKCR0aGlzLT5kYXRldGltZUZyb21EQigkcm93 WydjbG9zaW5nX2RhdGUnXSkpOwogCQkkcmVnaXN0cmF0aW9uT3B0aW9uLT5zZXRTZXF1ZW5jZSgk cm93WydzZXEnXSk7CiAJCSRyZWdpc3RyYXRpb25PcHRpb24tPnNldFB1YmxpYygkcm93WydwdWIn XSk7CiAKQEAgLTIxOSw3ICsyMTksNyBAQCBjbGFzcyBSZWdpc3RyYXRpb25PcHRpb25EQU8gZXh0 ZW5kcyBEQU8gewogCQkJCVZBTFVFUwogCQkJCSg/LCAlcywgJXMsID8sID8sID8pJywKIAkJCQkk dGhpcy0+ZGF0ZVRvREIoJHJlZ2lzdHJhdGlvbk9wdGlvbi0+Z2V0T3BlbmluZ0RhdGUoKSksCi0J CQkJJHRoaXMtPmRhdGVUb0RCKCRyZWdpc3RyYXRpb25PcHRpb24tPmdldENsb3NpbmdEYXRlKCkp CisJCQkJJHRoaXMtPmRhdGV0aW1lVG9EQigkcmVnaXN0cmF0aW9uT3B0aW9uLT5nZXRDbG9zaW5n RGF0ZSgpKQogCQkJKSwgYXJyYXkoCiAJCQkJKGludCkgJHJlZ2lzdHJhdGlvbk9wdGlvbi0+Z2V0 U2NoZWRDb25mSWQoKSwKIAkJCQkoaW50KSAkcmVnaXN0cmF0aW9uT3B0aW9uLT5nZXRQdWJsaWMo KSwKQEAgLTI1MCw3ICsyNTAsNyBAQCBjbGFzcyBSZWdpc3RyYXRpb25PcHRpb25EQU8gZXh0ZW5k cyBEQU8gewogCQkJCQljb2RlID0gPwogCQkJCVdIRVJFCW9wdGlvbl9pZCA9ID8nLAogCQkJCSR0 aGlzLT5kYXRlVG9EQigkcmVnaXN0cmF0aW9uT3B0aW9uLT5nZXRPcGVuaW5nRGF0ZSgpKSwKLQkJ CQkkdGhpcy0+ZGF0ZVRvREIoJHJlZ2lzdHJhdGlvbk9wdGlvbi0+Z2V0Q2xvc2luZ0RhdGUoKSkK KwkJCQkkdGhpcy0+ZGF0ZXRpbWVUb0RCKCRyZWdpc3RyYXRpb25PcHRpb24tPmdldENsb3NpbmdE YXRlKCkpCiAJCQkpLCBhcnJheSgKIAkJCQkoaW50KSAkcmVnaXN0cmF0aW9uT3B0aW9uLT5nZXRT Y2hlZENvbmZJZCgpLAogCQkJCShpbnQpICRyZWdpc3RyYXRpb25PcHRpb24tPmdldFB1YmxpYygp LAotLS0gYS9jbGFzc2VzL3JlZ2lzdHJhdGlvbi9SZWdpc3RyYXRpb25UeXBlREFPLmluYy5waHAK KysrIGIvY2xhc3Nlcy9yZWdpc3RyYXRpb24vUmVnaXN0cmF0aW9uVHlwZURBTy5pbmMucGhwCkBA IC0yMzQsNyArMjM0LDcgQEAgY2xhc3MgUmVnaXN0cmF0aW9uVHlwZURBTyBleHRlbmRzIERBTyB7 CiAJCSRyZWdpc3RyYXRpb25UeXBlLT5zZXRDb3N0KCRyb3dbJ2Nvc3QnXSk7CiAJCSRyZWdpc3Ry YXRpb25UeXBlLT5zZXRDdXJyZW5jeUNvZGVBbHBoYSgkcm93WydjdXJyZW5jeV9jb2RlX2FscGhh J10pOwogCQkkcmVnaXN0cmF0aW9uVHlwZS0+c2V0T3BlbmluZ0RhdGUoJHRoaXMtPmRhdGVGcm9t REIoJHJvd1snb3BlbmluZ19kYXRlJ10pKTsKLQkJJHJlZ2lzdHJhdGlvblR5cGUtPnNldENsb3Np bmdEYXRlKCR0aGlzLT5kYXRlRnJvbURCKCRyb3dbJ2Nsb3NpbmdfZGF0ZSddKSk7CisJCSRyZWdp c3RyYXRpb25UeXBlLT5zZXRDbG9zaW5nRGF0ZSgkdGhpcy0+ZGF0ZXRpbWVGcm9tREIoJHJvd1sn Y2xvc2luZ19kYXRlJ10pKTsKIAkJJHJlZ2lzdHJhdGlvblR5cGUtPnNldEV4cGlyeURhdGUoJHRo aXMtPmRhdGVGcm9tREIoJHJvd1snZXhwaXJ5X2RhdGUnXSkpOwogCQkkcmVnaXN0cmF0aW9uVHlw ZS0+c2V0QWNjZXNzKCRyb3dbJ2FjY2VzcyddKTsKIAkJJHJlZ2lzdHJhdGlvblR5cGUtPnNldElu c3RpdHV0aW9uYWwoJHJvd1snaW5zdGl0dXRpb25hbCddKTsKLS0tIGEvZGJzY3JpcHRzL3htbC9v Y3Nfc2NoZW1hLnhtbAorKysgYi9kYnNjcmlwdHMveG1sL29jc19zY2hlbWEueG1sCkBAIC0xMzgy LDcgKzEzODIsNyBAQAogCQk8L2ZpZWxkPgogCQk8ZmllbGQgbmFtZT0iY29kZSIgdHlwZT0iQzIi IHNpemU9IjgwIiAvPgogCQk8ZmllbGQgbmFtZT0ib3BlbmluZ19kYXRlIiB0eXBlPSJEIi8+Ci0J CTxmaWVsZCBuYW1lPSJjbG9zaW5nX2RhdGUiIHR5cGU9IkQiPgorCQk8ZmllbGQgbmFtZT0iY2xv c2luZ19kYXRlIiB0eXBlPSJUIj4KIAkJCTxOT1ROVUxMLz4KIAkJPC9maWVsZD4KIAkJPGZpZWxk IG5hbWU9InB1YiIgdHlwZT0iSTEiPgo=