4554 2009-07-27 19:44:00 -0700 Cannot re-order some sections 2013-01-25 10:57:33 -0800 1 1 1 Unclassified OJS Editors 2.3 PC Windows NT RESOLVED FIXED http://journals.sfu.ca/cshp/index.php/cjhp/editor/issueToc/7 P5 minor --- 1 kstranac pkp-support alec justin.gonder mattcrider 15965 kstranac 2009-07-27 19:44:36 -0700 When trying to re-order sections up or down the TOC, some will not move as expected. For example, the linked UP arrow for "Report From The Presidential Team" has no effect: http://journals.sfu.ca/cshp/index.php/cjhp/editor/moveSectionToc/7?d=u&newPos=16&sectionId=26 Also, the DOWN arrow for the "Index" section just above the "Report From the Presidential Team" section is not linked at all, providing no way to move this section down the TOC. Similar problems can be found in the following issues for this SFU-hosted journal: Vol 53 #5 Vol 54 #4 Vol 55 #5 Vol 56 #5 Vol 57 #5 Vol 58 #5 Vol 60 #5 Vol 61 #6 If this can be patched, could it be applied to this journal? 15976 mattcrider 2009-07-28 16:11:00 -0700 Kevin, do you know what steps they took to cause this? I reproduced the behavior once, but I can't for the life of me do it again. 15979 kstranac 2009-07-29 08:11:14 -0700 No, but I will ask them and cc you on the message. 15980 alec 2009-07-29 08:44:45 -0700 The most probable cause, OTOH, is something like an article being published to an issue in a section that wasn't previously part of the ToC. That's enough of a special case that it may not currently be handled properly. 15982 mattcrider 2009-07-29 10:44:25 -0700 No, its not quite as simple as that.. It seems to be a very special case, and I reproduced it once (actually, I had about 10 sections in one issue and about 8 of them didn't have links on the 'up' arrows)... But in trying to debug the problem I unset the custom ordering and have no idea how to reproduce the error! This heat wave might have made me stupid though. I did have the $sections array in pages/editor/IssueManagementHandler.inc.php printed out when the bug occurred though, and I noticed that $section[4] and sometimes $sections[5] was null for these sections in question, so its a handler and not a template problem. 16401 alec 2009-08-20 10:01:59 -0700 Matt, did you get any further on this one? 16402 mattcrider 2009-08-20 10:04:27 -0700 No -- I spent so much time trying to reproduce this! Would you be able to take a look? 16404 alec 2009-08-20 10:25:27 -0700 Can I set you up with a DB dump from CHSP? It can be duplicated there. 16405 mattcrider 2009-08-20 10:33:10 -0700 Sure, or I can take one down myself (Though I can't find them on lib-journals2 or 3) 16408 alec 2009-08-20 10:38:27 -0700 Matt, it's on lib-journals2 -- my typo, the install is called cshp (not chsp). See the URL above. 16457 2327 mattcrider 2009-08-21 18:05:33 -0700 Created attachment 2327 Patch against OJS pre-2.3 CVS Well, the reason this is occurring is because the custom_section_orders table is not being consistently maintained. For instance in volum 61, no 5 of CSHP, there is a section 26 (Report From The Presidential Team) that never doesn't exist in the custom_section_orders table, so the issue management handler thinks section 8 (News) is the last section and doesn't provide a down arrow link. I still can't really reproduce the problem, but I think it has something to do with the fact that when you delete an article that is the only article in the section, the section is not deleted from the custom_section_orders table. This patch fixes this bug. 16461 mattcrider 2009-08-21 18:10:25 -0700 Patch committed. Though I can't reproduce the problem and see if the patch actually fixes it, I think this is the only way the custom_section_orders table can get messed up. Also, the problem is very hard to reproduce. So I'm gonna mark this as closed :) 2327 2009-08-21 18:05:00 -0700 2009-08-21 18:05:33 -0700 Patch against OJS pre-2.3 CVS ojsSectionOrdering.patch text/plain 2488 mattcrider SW5kZXg6IGNsYXNzZXMvam91cm5hbC9TZWN0aW9uREFPLmluYy5waHAKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1Mg ZmlsZTogL2N2cy9vanMyL2NsYXNzZXMvam91cm5hbC9TZWN0aW9uREFPLmluYy5waHAsdgpyZXRy aWV2aW5nIHJldmlzaW9uIDEuNTYKZGlmZiAtdSAtcjEuNTYgU2VjdGlvbkRBTy5pbmMucGhwCi0t LSBjbGFzc2VzL2pvdXJuYWwvU2VjdGlvbkRBTy5pbmMucGhwCTI4IEp1bCAyMDA5IDE4OjEyOjQ2 IC0wMDAwCTEuNTYKKysrIGNsYXNzZXMvam91cm5hbC9TZWN0aW9uREFPLmluYy5waHAJMjIgQXVn IDIwMDkgMDE6MDI6MzQgLTAwMDAKQEAgLTQ0MSw2ICs0NDEsMjQgQEAKIAkJCSdERUxFVEUgRlJP TSBjdXN0b21fc2VjdGlvbl9vcmRlcnMgV0hFUkUgaXNzdWVfaWQgPSA/JywgJGlzc3VlSWQKIAkJ KTsKIAl9CisJCisJLyoqCisJICogRGVsZXRlIGEgc2VjdGlvbiBmcm9tIHRoZSBjdXN0b20gc2Vj dGlvbiBvcmRlciB0YWJsZS4KKwkgKiBAcGFyYW0gJGlzc3VlSWQgaW50CisJICogQHBhcmFtICRz ZWN0aW9uSWQgaW50CSAKKwkgKi8KKwlmdW5jdGlvbiBkZWxldGVDdXN0b21TZWN0aW9uKCRpc3N1 ZUlkLCAkc2VjdGlvbklkKSB7CisJCSRzZXF1ZW5jZSA9ICR0aGlzLT5nZXRDdXN0b21TZWN0aW9u T3JkZXIoJGlzc3VlSWQsICRzZWN0aW9uSWQpOworCQkKKwkJJHRoaXMtPnVwZGF0ZSgKKwkJCSdE RUxFVEUgRlJPTSBjdXN0b21fc2VjdGlvbl9vcmRlcnMgV0hFUkUgaXNzdWVfaWQgPSA/IEFORCBz ZWN0aW9uX2lkID0gPycsIGFycmF5KCRpc3N1ZUlkLCAkc2VjdGlvbklkKQorCQkpOworCQkKKwkJ Ly8gUmVkdWNlIHRoZSBzZWN0aW9uIG9yZGVyIG9mIGV2ZXJ5IHN1Y2Nlc3NpdmUgc2VjdGlvbiBi eSBvbmUJCQorCQkkdGhpcy0+dXBkYXRlKAorCQkJJ1VQREFURSBjdXN0b21fc2VjdGlvbl9vcmRl cnMgU0VUIHNlcSA9IHNlcSAtIDEgV0hFUkUgaXNzdWVfaWQgPSA/IEFORCBzZXEgPiA/JywgYXJy YXkoJGlzc3VlSWQsICRzZXF1ZW5jZSkKKwkJKTsKKwl9CiAKIAkvKioKIAkgKiBTZXF1ZW50aWFs bHkgcmVudW1iZXIgY3VzdG9tIHNlY3Rpb24gb3JkZXJpbmdzIGluIHRoZWlyIHNlcXVlbmNlIG9y ZGVyLgpJbmRleDogcGFnZXMvZWRpdG9yL0lzc3VlTWFuYWdlbWVudEhhbmRsZXIuaW5jLnBocAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09ClJDUyBmaWxlOiAvY3ZzL29qczIvcGFnZXMvZWRpdG9yL0lzc3VlTWFuYWdlbWVu dEhhbmRsZXIuaW5jLnBocCx2CnJldHJpZXZpbmcgcmV2aXNpb24gMS45NwpkaWZmIC11IC1yMS45 NyBJc3N1ZU1hbmFnZW1lbnRIYW5kbGVyLmluYy5waHAKLS0tIHBhZ2VzL2VkaXRvci9Jc3N1ZU1h bmFnZW1lbnRIYW5kbGVyLmluYy5waHAJMTAgQXVnIDIwMDkgMjI6NDI6MDAgLTAwMDAJMS45Nwor KysgcGFnZXMvZWRpdG9yL0lzc3VlTWFuYWdlbWVudEhhbmRsZXIuaW5jLnBocAkyMiBBdWcgMjAw OSAwMTowMjozNSAtMDAwMApAQCAtMzY3LDYgKzM2Nyw3IEBACiAKIAkJJGFydGljbGVEYW8gPSYg REFPUmVnaXN0cnk6OmdldERBTygnQXJ0aWNsZURBTycpOwogCQkkcHVibGlzaGVkQXJ0aWNsZURh byA9JiBEQU9SZWdpc3RyeTo6Z2V0REFPKCdQdWJsaXNoZWRBcnRpY2xlREFPJyk7CisJCSRzZWN0 aW9uRGFvID0mIERBT1JlZ2lzdHJ5OjpnZXREQU8oJ1NlY3Rpb25EQU8nKTsKIAogCQkkYXJ0aWNs ZXMgPSAkcHVibGlzaGVkQXJ0aWNsZURhby0+Z2V0UHVibGlzaGVkQXJ0aWNsZXMoJGlzc3VlSWQp OwogCkBAIC0zODksNiArMzkwLDE0IEBACiAJCQl9IGVsc2UgewogCQkJCSRhcnRpY2xlLT5zZXRT dGF0dXMoU1RBVFVTX1FVRVVFRCk7CiAJCQkJJGFydGljbGUtPnN0YW1wU3RhdHVzTW9kaWZpZWQo KTsKKwkJCQkKKwkJCQkvLyBJZiB0aGUgYXJ0aWNsZSBpcyB0aGUgb25seSBvbmUgaW4gdGhlIHNl Y3Rpb24sIGRlbGV0ZSB0aGUgc2VjdGlvbiBmcm9tIGN1c3RvbSBpc3N1ZSBvcmRlcmluZwkJCQkK KwkJCQkkc2VjdGlvbklkID0gJGFydGljbGUtPmdldFNlY3Rpb25JZCgpOworCQkJCSRwdWJsaXNo ZWRBcnRpY2xlQXJyYXkgPSYgJHB1Ymxpc2hlZEFydGljbGVEYW8tPmdldFB1Ymxpc2hlZEFydGlj bGVzQnlTZWN0aW9uSWQoJHNlY3Rpb25JZCwgJGlzc3VlSWQpOworCQkJCWlmIChzaXplb2YoJHB1 Ymxpc2hlZEFydGljbGVBcnJheSkgPT0gMSkgeworCQkJCQkkc2VjdGlvbkRhby0+ZGVsZXRlQ3Vz dG9tU2VjdGlvbigkaXNzdWVJZCwgJHNlY3Rpb25JZCk7CisJCQkJfQorCQkJCQogCQkJCSRwdWJs aXNoZWRBcnRpY2xlRGFvLT5kZWxldGVQdWJsaXNoZWRBcnRpY2xlQnlJZCgkcHViSWQpOwogCQkJ CSRwdWJsaXNoZWRBcnRpY2xlRGFvLT5yZXNlcXVlbmNlUHVibGlzaGVkQXJ0aWNsZXMoJGFydGlj bGUtPmdldFNlY3Rpb25JZCgpLCAkaXNzdWVJZCk7CiAJCQl9Cg==