<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "http://pkp.sfu.ca/bugzilla/bugzilla.dtd">

<bugzilla version="4.2.5+"
          urlbase="http://pkp.sfu.ca/bugzilla/"
          
          maintainer="pkp-hosted@sfu.ca"
>

    <bug>
          <bug_id>3790</bug_id>
          
          <creation_ts>2008-09-26 03:26:00 -0700</creation_ts>
          <short_desc>DB Error: Incorrect integer value: &apos;&apos; for column &apos;review_form_id&apos; at row 1</short_desc>
          <delta_ts>2011-07-06 08:25:37 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>OJS</product>
          <component>Journal Management</component>
          <version>2.2.3</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Linux</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P1</priority>
          <bug_severity>major</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Fanrien">fanrien</reporter>
          <assigned_to name="Alec Smecher">alec</assigned_to>
          <cc>dkaloper</cc>
    
    <cc>fanrien</cc>
    
    <cc>magonzalez</cc>
    
    <cc>mikey.willis</cc>
    
    <cc>pkp-support</cc>
          
          

      

      

      

          <long_desc isprivate="0">
            <commentid>12173</commentid>
            <who name="Fanrien">fanrien</who>
            <bug_when>2008-09-26 03:26:17 -0700</bug_when>
            <thetext>When I create a new section, the system reports this: &quot;DB Error: Incorrect integer value: &apos;&apos; for column &apos;review_form_id&apos; at row 1&quot;.

And I have set a section editor, but it did not show on &quot;Available Section Editors&quot;.

How can I do?</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>12174</commentid>
              <attachid>987</attachid>
            <who name="Alec Smecher">alec</who>
            <bug_when>2008-09-26 09:09:37 -0700</bug_when>
            <thetext>Created attachment 987
Patch against OJS 2.2.1</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>12175</commentid>
              <attachid>988</attachid>
            <who name="Alec Smecher">alec</who>
            <bug_when>2008-09-26 09:13:19 -0700</bug_when>
            <thetext>Created attachment 988
Patch against OJS 2.2.2</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>12176</commentid>
            <who name="Alec Smecher">alec</who>
            <bug_when>2008-09-26 09:13:57 -0700</bug_when>
            <thetext>Attached patch a) ensures that blank review form IDs are cast to null, and b) the section editor list is removed from the &quot;create section&quot; form (but available on &quot;edit section&quot;).</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>12186</commentid>
            <who name="Alec Smecher">alec</who>
            <bug_when>2008-09-28 19:43:25 -0700</bug_when>
            <thetext>*** Bug 3793 has been marked as a duplicate of this bug. ***</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>12187</commentid>
            <who name="Fanrien">fanrien</who>
            <bug_when>2008-09-28 19:52:44 -0700</bug_when>
            <thetext>WebServer2 htdocs # ls
Bug3790patch  classes         config.TEMPLATE.inc.php  docs  includes   js   locale    pages    public    rt      templates
cache         config.inc.php  dbscripts                help  index.php  lib  logo.jpg  plugins  registry  styles  tools
WebServer2 htdocs # cat Bug3790patch
diff -u -r1.37 SectionForm.inc.php
--- classes/manager/form/SectionForm.inc.php    1 Jul 2008 01:16:10 -0000       1.37
+++ classes/manager/form/SectionForm.inc.php    26 Sep 2008 16:09:00 -0000
@@ -206,7 +206,9 @@

                $section-&gt;setTitle($this-&gt;getData(&apos;title&apos;), null); // Localized
                $section-&gt;setAbbrev($this-&gt;getData(&apos;abbrev&apos;), null); // Localized
-               $section-&gt;setReviewFormId($this-&gt;getData(&apos;reviewFormId&apos;));
+               $reviewFormId = $this-&gt;getData(&apos;reviewFormId&apos;);
+               if ($reviewFormId === &apos;&apos;) $reviewFormId = null;
+               $section-&gt;setReviewFormId($reviewFormId);
                $section-&gt;setMetaIndexed($this-&gt;getData(&apos;metaIndexed&apos;) ? 0 : 1); // #2066: Inverted
                $section-&gt;setMetaReviewed($this-&gt;getData(&apos;metaReviewed&apos;) ? 0 : 1); // #2066: Inverted
                $section-&gt;setAbstractsNotRequired($this-&gt;getData(&apos;abstractsNotRequired&apos;) ? 1 : 0);
diff -u -r1.44 sectionForm.tpl
--- templates/manager/sections/sectionForm.tpl  9 Jul 2008 02:45:40 -0000       1.44
+++ templates/manager/sections/sectionForm.tpl  26 Sep 2008 16:12:37 -0000
@@ -154,6 +154,8 @@
 &lt;/tr&gt;
 {/if}
 &lt;/table&gt;
+
+{if $sectionId}{* Disable section editor selection if this is a new section *}
 &lt;div class=&quot;separator&quot;&gt;&lt;/div&gt;

 &lt;h3&gt;{translate key=&quot;user.role.sectionEditors&quot;}&lt;/h3&gt;
@@ -229,6 +231,8 @@
        &lt;/tr&gt;
 &lt;/table&gt;

+{/if}{* $sectionId *}
+
 &lt;p&gt;&lt;input type=&quot;submit&quot; value=&quot;{translate key=&quot;common.save&quot;}&quot; class=&quot;button defaultButton&quot; /&gt; &lt;input type=&quot;button&quot; value=&quot;{translate key=&quot;common.cancel&quot;}&quot; class=&quot;button&quot; onclick=&quot;document.location.href=&apos;{url op=&quot;sections&quot; escape=false}&apos;&quot; /&gt;&lt;/p&gt;

 &lt;/form&gt;
WebServer2 htdocs # patch -p1 &lt; Bug3790patch
can&apos;t find file to patch at input line 4
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff -u -r1.37 SectionForm.inc.php
|--- classes/manager/form/SectionForm.inc.php   1 Jul 2008 01:16:10 -0000       1.37
|+++ classes/manager/form/SectionForm.inc.php   26 Sep 2008 16:09:00 -0000
--------------------------
File to patch:

================================================================
Dear all, why the patch program can&apos;t find the file?
Path and version are exactly correct.
Please advise.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>12188</commentid>
            <who name="Alec Smecher">alec</who>
            <bug_when>2008-09-28 19:54:55 -0700</bug_when>
            <thetext>Try using -p0 instead of -p1.</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>12207</commentid>
            <who name="Alec Smecher">alec</who>
            <bug_when>2008-10-02 08:06:18 -0700</bug_when>
            <thetext>*** Bug 3796 has been marked as a duplicate of this bug. ***</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>12211</commentid>
              <attachid>1002</attachid>
            <who name="Alec Smecher">alec</who>
            <bug_when>2008-10-02 09:06:21 -0700</bug_when>
            <thetext>Created attachment 1002
Additional patch against OJS 2.2.2</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>12213</commentid>
            <who name="Alec Smecher">alec</who>
            <bug_when>2008-10-02 09:08:15 -0700</bug_when>
            <thetext>*** Bug 3796 has been marked as a duplicate of this bug. ***</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>13588</commentid>
              <attachid>1435</attachid>
            <who name="Rui">crisostomo</who>
            <bug_when>2009-02-12 04:32:14 -0800</bug_when>
            <thetext>Created attachment 1435
Patch</thetext>
          </long_desc>
          <long_desc isprivate="0">
            <commentid>13589</commentid>
            <who name="Alec Smecher">alec</who>
            <bug_when>2009-02-12 06:40:23 -0800</bug_when>
            <thetext>Rui, is this an additional fix? If so, could you send a unified diff (generated using &quot;diff -u&quot;) instead of the complete modified file?</thetext>
          </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>987</attachid>
            <date>2008-09-26 09:09:00 -0700</date>
            <delta_ts>2008-09-26 09:13:19 -0700</delta_ts>
            <desc>Patch against OJS 2.2.1</desc>
            <filename>3790.diff</filename>
            <type>text/plain</type>
            <size>812</size>
            <attacher>alec</attacher>
            
              <data encoding="base64">ZGlmZiAtdSAtcjEuMzcgU2VjdGlvbkZvcm0uaW5jLnBocAotLS0gY2xhc3Nlcy9tYW5hZ2VyL2Zv
cm0vU2VjdGlvbkZvcm0uaW5jLnBocAkxIEp1bCAyMDA4IDAxOjE2OjEwIC0wMDAwCTEuMzcKKysr
IGNsYXNzZXMvbWFuYWdlci9mb3JtL1NlY3Rpb25Gb3JtLmluYy5waHAJMjYgU2VwIDIwMDggMTY6
MDk6MDAgLTAwMDAKQEAgLTIwNiw3ICsyMDYsOSBAQAogCiAJCSRzZWN0aW9uLT5zZXRUaXRsZSgk
dGhpcy0+Z2V0RGF0YSgndGl0bGUnKSwgbnVsbCk7IC8vIExvY2FsaXplZAogCQkkc2VjdGlvbi0+
c2V0QWJicmV2KCR0aGlzLT5nZXREYXRhKCdhYmJyZXYnKSwgbnVsbCk7IC8vIExvY2FsaXplZAot
CQkkc2VjdGlvbi0+c2V0UmV2aWV3Rm9ybUlkKCR0aGlzLT5nZXREYXRhKCdyZXZpZXdGb3JtSWQn
KSk7CisJCSRyZXZpZXdGb3JtSWQgPSAkdGhpcy0+Z2V0RGF0YSgncmV2aWV3Rm9ybUlkJyk7CisJ
CWlmICgkcmV2aWV3Rm9ybUlkID09PSAnJykgJHJldmlld0Zvcm1JZCA9IG51bGw7CisJCSRzZWN0
aW9uLT5zZXRSZXZpZXdGb3JtSWQoJHJldmlld0Zvcm1JZCk7CiAJCSRzZWN0aW9uLT5zZXRNZXRh
SW5kZXhlZCgkdGhpcy0+Z2V0RGF0YSgnbWV0YUluZGV4ZWQnKSA/IDAgOiAxKTsgLy8gIzIwNjY6
IEludmVydGVkCiAJCSRzZWN0aW9uLT5zZXRNZXRhUmV2aWV3ZWQoJHRoaXMtPmdldERhdGEoJ21l
dGFSZXZpZXdlZCcpID8gMCA6IDEpOyAvLyAjMjA2NjogSW52ZXJ0ZWQKIAkJJHNlY3Rpb24tPnNl
dEFic3RyYWN0c05vdFJlcXVpcmVkKCR0aGlzLT5nZXREYXRhKCdhYnN0cmFjdHNOb3RSZXF1aXJl
ZCcpID8gMSA6IDApOwo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>988</attachid>
            <date>2008-09-26 09:13:00 -0700</date>
            <delta_ts>2008-09-26 09:13:19 -0700</delta_ts>
            <desc>Patch against OJS 2.2.2</desc>
            <filename>3790.diff</filename>
            <type>text/plain</type>
            <size>1529</size>
            <attacher>alec</attacher>
            
              <data encoding="base64">ZGlmZiAtdSAtcjEuMzcgU2VjdGlvbkZvcm0uaW5jLnBocAotLS0gY2xhc3Nlcy9tYW5hZ2VyL2Zv
cm0vU2VjdGlvbkZvcm0uaW5jLnBocAkxIEp1bCAyMDA4IDAxOjE2OjEwIC0wMDAwCTEuMzcKKysr
IGNsYXNzZXMvbWFuYWdlci9mb3JtL1NlY3Rpb25Gb3JtLmluYy5waHAJMjYgU2VwIDIwMDggMTY6
MDk6MDAgLTAwMDAKQEAgLTIwNiw3ICsyMDYsOSBAQAogCiAJCSRzZWN0aW9uLT5zZXRUaXRsZSgk
dGhpcy0+Z2V0RGF0YSgndGl0bGUnKSwgbnVsbCk7IC8vIExvY2FsaXplZAogCQkkc2VjdGlvbi0+
c2V0QWJicmV2KCR0aGlzLT5nZXREYXRhKCdhYmJyZXYnKSwgbnVsbCk7IC8vIExvY2FsaXplZAot
CQkkc2VjdGlvbi0+c2V0UmV2aWV3Rm9ybUlkKCR0aGlzLT5nZXREYXRhKCdyZXZpZXdGb3JtSWQn
KSk7CisJCSRyZXZpZXdGb3JtSWQgPSAkdGhpcy0+Z2V0RGF0YSgncmV2aWV3Rm9ybUlkJyk7CisJ
CWlmICgkcmV2aWV3Rm9ybUlkID09PSAnJykgJHJldmlld0Zvcm1JZCA9IG51bGw7CisJCSRzZWN0
aW9uLT5zZXRSZXZpZXdGb3JtSWQoJHJldmlld0Zvcm1JZCk7CiAJCSRzZWN0aW9uLT5zZXRNZXRh
SW5kZXhlZCgkdGhpcy0+Z2V0RGF0YSgnbWV0YUluZGV4ZWQnKSA/IDAgOiAxKTsgLy8gIzIwNjY6
IEludmVydGVkCiAJCSRzZWN0aW9uLT5zZXRNZXRhUmV2aWV3ZWQoJHRoaXMtPmdldERhdGEoJ21l
dGFSZXZpZXdlZCcpID8gMCA6IDEpOyAvLyAjMjA2NjogSW52ZXJ0ZWQKIAkJJHNlY3Rpb24tPnNl
dEFic3RyYWN0c05vdFJlcXVpcmVkKCR0aGlzLT5nZXREYXRhKCdhYnN0cmFjdHNOb3RSZXF1aXJl
ZCcpID8gMSA6IDApOwpkaWZmIC11IC1yMS40NCBzZWN0aW9uRm9ybS50cGwKLS0tIHRlbXBsYXRl
cy9tYW5hZ2VyL3NlY3Rpb25zL3NlY3Rpb25Gb3JtLnRwbAk5IEp1bCAyMDA4IDAyOjQ1OjQwIC0w
MDAwCTEuNDQKKysrIHRlbXBsYXRlcy9tYW5hZ2VyL3NlY3Rpb25zL3NlY3Rpb25Gb3JtLnRwbAky
NiBTZXAgMjAwOCAxNjoxMjozNyAtMDAwMApAQCAtMTU0LDYgKzE1NCw4IEBACiA8L3RyPgogey9p
Zn0KIDwvdGFibGU+CisKK3tpZiAkc2VjdGlvbklkfXsqIERpc2FibGUgc2VjdGlvbiBlZGl0b3Ig
c2VsZWN0aW9uIGlmIHRoaXMgaXMgYSBuZXcgc2VjdGlvbiAqfQogPGRpdiBjbGFzcz0ic2VwYXJh
dG9yIj48L2Rpdj4KIAogPGgzPnt0cmFuc2xhdGUga2V5PSJ1c2VyLnJvbGUuc2VjdGlvbkVkaXRv
cnMifTwvaDM+CkBAIC0yMjksNiArMjMxLDggQEAKIAk8L3RyPgogPC90YWJsZT4KIAorey9pZn17
KiAkc2VjdGlvbklkICp9CisKIDxwPjxpbnB1dCB0eXBlPSJzdWJtaXQiIHZhbHVlPSJ7dHJhbnNs
YXRlIGtleT0iY29tbW9uLnNhdmUifSIgY2xhc3M9ImJ1dHRvbiBkZWZhdWx0QnV0dG9uIiAvPiA8
aW5wdXQgdHlwZT0iYnV0dG9uIiB2YWx1ZT0ie3RyYW5zbGF0ZSBrZXk9ImNvbW1vbi5jYW5jZWwi
fSIgY2xhc3M9ImJ1dHRvbiIgb25jbGljaz0iZG9jdW1lbnQubG9jYXRpb24uaHJlZj0ne3VybCBv
cD0ic2VjdGlvbnMiIGVzY2FwZT1mYWxzZX0nIiAvPjwvcD4KIAogPC9mb3JtPgo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>1002</attachid>
            <date>2008-10-02 09:06:00 -0700</date>
            <delta_ts>2008-10-02 09:06:21 -0700</delta_ts>
            <desc>Additional patch against OJS 2.2.2</desc>
            <filename>3790.diff</filename>
            <type>text/plain</type>
            <size>2059</size>
            <attacher>alec</attacher>
            
              <data encoding="base64">ZGlmZiAtdSAtcjEuMzcuMi4xIFNlY3Rpb25Gb3JtLmluYy5waHAKLS0tIGNsYXNzZXMvbWFuYWdl
ci9mb3JtL1NlY3Rpb25Gb3JtLmluYy5waHAJMjYgU2VwIDIwMDggMTY6MTQ6MzAgLTAwMDAJMS4z
Ny4yLjEKKysrIGNsYXNzZXMvbWFuYWdlci9mb3JtL1NlY3Rpb25Gb3JtLmluYy5waHAJMiBPY3Qg
MjAwOCAxNjowNTowMyAtMDAwMApAQCAtMTIxLDE1ICsxMjEsMTUgQEAKIAkgKiBJbml0aWFsaXpl
IGZvcm0gZGF0YSBmcm9tIGN1cnJlbnQgc2V0dGluZ3MuCiAJICovCiAJZnVuY3Rpb24gaW5pdERh
dGEoKSB7CisJCSRqb3VybmFsID0gJlJlcXVlc3Q6OmdldEpvdXJuYWwoKTsKKwkJJHNlY3Rpb25F
ZGl0b3JzRGFvID0mIERBT1JlZ2lzdHJ5OjpnZXREQU8oJ1NlY3Rpb25FZGl0b3JzREFPJyk7CiAJ
CWlmIChpc3NldCgkdGhpcy0+c2VjdGlvbklkKSkgewotCQkJJGpvdXJuYWwgPSAmUmVxdWVzdDo6
Z2V0Sm91cm5hbCgpOwotCQkJJHNlY3Rpb25EYW8gPSAmREFPUmVnaXN0cnk6OmdldERBTygnU2Vj
dGlvbkRBTycpOwotCQkJJHNlY3Rpb24gPSAmJHNlY3Rpb25EYW8tPmdldFNlY3Rpb24oJHRoaXMt
PnNlY3Rpb25JZCwgJGpvdXJuYWwtPmdldEpvdXJuYWxJZCgpKTsKKwkJCSRzZWN0aW9uRGFvID0m
IERBT1JlZ2lzdHJ5OjpnZXREQU8oJ1NlY3Rpb25EQU8nKTsKKwkJCSRzZWN0aW9uID0mICRzZWN0
aW9uRGFvLT5nZXRTZWN0aW9uKCR0aGlzLT5zZWN0aW9uSWQsICRqb3VybmFsLT5nZXRKb3VybmFs
SWQoKSk7CiAKIAkJCWlmICgkc2VjdGlvbiA9PSBudWxsKSB7CiAJCQkJdW5zZXQoJHRoaXMtPnNl
Y3Rpb25JZCk7CiAJCQl9IGVsc2UgewotCQkJCSRzZWN0aW9uRWRpdG9yc0RhbyA9JiBEQU9SZWdp
c3RyeTo6Z2V0REFPKCdTZWN0aW9uRWRpdG9yc0RBTycpOwogCQkJCSR0aGlzLT5fZGF0YSA9IGFy
cmF5KAogCQkJCQkndGl0bGUnID0+ICRzZWN0aW9uLT5nZXRUaXRsZShudWxsKSwgLy8gTG9jYWxp
emVkCiAJCQkJCSdhYmJyZXYnID0+ICRzZWN0aW9uLT5nZXRBYmJyZXYobnVsbCksIC8vIExvY2Fs
aXplZApAQCAtMTQ4LDYgKzE0OCwxMCBAQAogCQkJCQkndW5hc3NpZ25lZEVkaXRvcnMnID0+ICRz
ZWN0aW9uRWRpdG9yc0Rhby0+Z2V0RWRpdG9yc05vdEluU2VjdGlvbigkam91cm5hbC0+Z2V0Sm91
cm5hbElkKCksICR0aGlzLT5zZWN0aW9uSWQpCiAJCQkJKTsKIAkJCX0KKwkJfSBlbHNlIHsKKwkJ
CSR0aGlzLT5fZGF0YSA9IGFycmF5KAorCQkJCSd1bmFzc2lnbmVkRWRpdG9ycycgPT4gJHNlY3Rp
b25FZGl0b3JzRGFvLT5nZXRFZGl0b3JzTm90SW5TZWN0aW9uKCRqb3VybmFsLT5nZXRKb3VybmFs
SWQoKSwgbnVsbCkKKwkJCSk7CiAJCX0KIAl9CiAKZGlmZiAtdSAtcjEuNDQuMi4xIHNlY3Rpb25G
b3JtLnRwbAotLS0gdGVtcGxhdGVzL21hbmFnZXIvc2VjdGlvbnMvc2VjdGlvbkZvcm0udHBsCTI2
IFNlcCAyMDA4IDE2OjE0OjMwIC0wMDAwCTEuNDQuMi4xCisrKyB0ZW1wbGF0ZXMvbWFuYWdlci9z
ZWN0aW9ucy9zZWN0aW9uRm9ybS50cGwJMiBPY3QgMjAwOCAxNjowNTozMyAtMDAwMApAQCAtMTU1
LDcgKzE1NSw2IEBACiB7L2lmfQogPC90YWJsZT4KIAote2lmICRzZWN0aW9uSWR9eyogRGlzYWJs
ZSBzZWN0aW9uIGVkaXRvciBzZWxlY3Rpb24gaWYgdGhpcyBpcyBhIG5ldyBzZWN0aW9uICp9CiA8
ZGl2IGNsYXNzPSJzZXBhcmF0b3IiPjwvZGl2PgogCiA8aDM+e3RyYW5zbGF0ZSBrZXk9InVzZXIu
cm9sZS5zZWN0aW9uRWRpdG9ycyJ9PC9oMz4KQEAgLTIzMSw4ICsyMzAsNiBAQAogCTwvdHI+CiA8
L3RhYmxlPgogCi17L2lmfXsqICRzZWN0aW9uSWQgKn0KLQogPHA+PGlucHV0IHR5cGU9InN1Ym1p
dCIgdmFsdWU9Int0cmFuc2xhdGUga2V5PSJjb21tb24uc2F2ZSJ9IiBjbGFzcz0iYnV0dG9uIGRl
ZmF1bHRCdXR0b24iIC8+IDxpbnB1dCB0eXBlPSJidXR0b24iIHZhbHVlPSJ7dHJhbnNsYXRlIGtl
eT0iY29tbW9uLmNhbmNlbCJ9IiBjbGFzcz0iYnV0dG9uIiBvbmNsaWNrPSJkb2N1bWVudC5sb2Nh
dGlvbi5ocmVmPSd7dXJsIG9wPSJzZWN0aW9ucyIgZXNjYXBlPWZhbHNlfSciIC8+PC9wPgogCiA8
L2Zvcm0+Cg==
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="0"
              isprivate="0"
          >
            <attachid>1435</attachid>
            <date>2009-02-12 04:32:00 -0800</date>
            <delta_ts>2009-02-12 04:33:04 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>CreateReviewerForm.inc.php</filename>
            <type>text/plain</type>
            <size>6489</size>
            <attacher>crisostomo</attacher>
            
              <data encoding="base64">PD9waHAKCi8qKgogKiBAZGVmZ3JvdXAgc2VjdGlvbkVkaXRvcl9mb3JtCiAqLwogCgovKioKICog
QGZpbGUgY2xhc3Nlcy9zZWN0aW9uRWRpdG9yL2Zvcm0vQ3JlYXRlUmV2aWV3ZXJGb3JtLmluYy5w
aHAKICoKICogQ29weXJpZ2h0IChjKSAyMDAzLTIwMDggSm9obiBXaWxsaW5za3kKICogRGlzdHJp
YnV0ZWQgdW5kZXIgdGhlIEdOVSBHUEwgdjIuIEZvciBmdWxsIHRlcm1zIHNlZSB0aGUgZmlsZSBk
b2NzL0NPUFlJTkcuCiAqCiAqIEBjbGFzcyBDcmVhdGVSZXZpZXdlckZvcm0KICogQGluZ3JvdXAg
c2VjdGlvbkVkaXRvcl9mb3JtCiAqCiAqIEBicmllZiBGb3JtIGZvciBzZWN0aW9uIGVkaXRvcnMg
dG8gY3JlYXRlIHJldmlld2Vycy4KICovCgovLyAkSWQ6IENyZWF0ZVJldmlld2VyRm9ybS5pbmMu
cGhwLHYgMS4xNSAyMDA4LzA3LzAxIDAxOjE2OjEwIGFzbWVjaGVyIEV4cCAkCgoKaW1wb3J0KCdm
b3JtLkZvcm0nKTsKCmNsYXNzIENyZWF0ZVJldmlld2VyRm9ybSBleHRlbmRzIEZvcm0gewoJLyoq
IEB2YXIgaW50IFRoZSBhcnRpY2xlIHRoaXMgZm9ybSBpcyBmb3IgKi8KCXZhciAkYXJ0aWNsZUlk
OwoKCS8qKgoJICogQ29uc3RydWN0b3IuCgkgKi8KCWZ1bmN0aW9uIENyZWF0ZVJldmlld2VyRm9y
bSgkYXJ0aWNsZUlkKSB7CgkJcGFyZW50OjpGb3JtKCdzZWN0aW9uRWRpdG9yL2NyZWF0ZVJldmll
d2VyRm9ybS50cGwnKTsKCQkkdGhpcy0+YWRkQ2hlY2sobmV3IEZvcm1WYWxpZGF0b3JQb3N0KCR0
aGlzKSk7CgoJCSRzaXRlID0gJlJlcXVlc3Q6OmdldFNpdGUoKTsKCQkkdGhpcy0+YXJ0aWNsZUlk
ID0gJGFydGljbGVJZDsKCgkJLy8gVmFsaWRhdGlvbiBjaGVja3MgZm9yIHRoaXMgZm9ybQoJCSR0
aGlzLT5hZGRDaGVjayhuZXcgRm9ybVZhbGlkYXRvcigkdGhpcywgJ3VzZXJuYW1lJywgJ3JlcXVp
cmVkJywgJ3VzZXIucHJvZmlsZS5mb3JtLnVzZXJuYW1lUmVxdWlyZWQnKSk7CgkJJHRoaXMtPmFk
ZENoZWNrKG5ldyBGb3JtVmFsaWRhdG9yQ3VzdG9tKCR0aGlzLCAndXNlcm5hbWUnLCAncmVxdWly
ZWQnLCAndXNlci5yZWdpc3Rlci5mb3JtLnVzZXJuYW1lRXhpc3RzJywgYXJyYXkoREFPUmVnaXN0
cnk6OmdldERBTygnVXNlckRBTycpLCAndXNlckV4aXN0c0J5VXNlcm5hbWUnKSwgYXJyYXkobnVs
bCwgdHJ1ZSksIHRydWUpKTsKCQkkdGhpcy0+YWRkQ2hlY2sobmV3IEZvcm1WYWxpZGF0b3JBbHBo
YU51bSgkdGhpcywgJ3VzZXJuYW1lJywgJ3JlcXVpcmVkJywgJ3VzZXIucmVnaXN0ZXIuZm9ybS51
c2VybmFtZUFscGhhTnVtZXJpYycpKTsKCQkkdGhpcy0+YWRkQ2hlY2sobmV3IEZvcm1WYWxpZGF0
b3IoJHRoaXMsICdmaXJzdE5hbWUnLCAncmVxdWlyZWQnLCAndXNlci5wcm9maWxlLmZvcm0uZmly
c3ROYW1lUmVxdWlyZWQnKSk7CgkJJHRoaXMtPmFkZENoZWNrKG5ldyBGb3JtVmFsaWRhdG9yKCR0
aGlzLCAnbGFzdE5hbWUnLCAncmVxdWlyZWQnLCAndXNlci5wcm9maWxlLmZvcm0ubGFzdE5hbWVS
ZXF1aXJlZCcpKTsKCQkkdGhpcy0+YWRkQ2hlY2sobmV3IEZvcm1WYWxpZGF0b3JVcmwoJHRoaXMs
ICd1c2VyVXJsJywgJ29wdGlvbmFsJywgJ3VzZXIucHJvZmlsZS5mb3JtLnVybEludmFsaWQnKSk7
CgkJJHRoaXMtPmFkZENoZWNrKG5ldyBGb3JtVmFsaWRhdG9yRW1haWwoJHRoaXMsICdlbWFpbCcs
ICdyZXF1aXJlZCcsICd1c2VyLnByb2ZpbGUuZm9ybS5lbWFpbFJlcXVpcmVkJykpOwoJCSR0aGlz
LT5hZGRDaGVjayhuZXcgRm9ybVZhbGlkYXRvckN1c3RvbSgkdGhpcywgJ2VtYWlsJywgJ3JlcXVp
cmVkJywgJ3VzZXIucmVnaXN0ZXIuZm9ybS5lbWFpbEV4aXN0cycsIGFycmF5KERBT1JlZ2lzdHJ5
OjpnZXREQU8oJ1VzZXJEQU8nKSwgJ3VzZXJFeGlzdHNCeUVtYWlsJyksIGFycmF5KG51bGwsIHRy
dWUpLCB0cnVlKSk7CgoJCS8vIFByb3ZpZGUgYSBkZWZhdWx0IGZvciBzZW5kTm90aWZ5OiBJZiB3
ZSdyZSB1c2luZyBvbmUtY2xpY2sKCQkvLyByZXZpZXdlciBhY2Nlc3Mgb3IgZW1haWwtYmFzZWQg
cmV2aWV3cywgaXQncyBub3QgbmVjZXNzYXJ5OwoJCS8vIG90aGVyd2lzZSwgaXQgc2hvdWxkIGRl
ZmF1bHQgdG8gb24uCgkJJGpvdXJuYWwgPSYgUmVxdWVzdDo6Z2V0Sm91cm5hbCgpOwoJCSRyZXZp
ZXdlckFjY2Vzc0tleXNFbmFibGVkID0gJGpvdXJuYWwtPmdldFNldHRpbmcoJ3Jldmlld2VyQWNj
ZXNzS2V5c0VuYWJsZWQnKTsKCQkkaXNFbWFpbEJhc2VkUmV2aWV3ID0gJGpvdXJuYWwtPmdldFNl
dHRpbmcoJ21haWxTdWJtaXNzaW9uc1RvUmV2aWV3ZXJzJyk9PTE/dHJ1ZTpmYWxzZTsKCQkkdGhp
cy0+c2V0RGF0YSgnc2VuZE5vdGlmeScsICgkcmV2aWV3ZXJBY2Nlc3NLZXlzRW5hYmxlZCB8fCAk
aXNFbWFpbEJhc2VkUmV2aWV3KT9mYWxzZTp0cnVlKTsKCX0KCglmdW5jdGlvbiBnZXRMb2NhbGVG
aWVsZE5hbWVzKCkgewoJCXJldHVybiBhcnJheSgnYmlvZ3JhcGh5JywgJ2ludGVyZXN0cycpOwoJ
fQoKCS8qKgoJICogRGlzcGxheSB0aGUgZm9ybS4KCSAqLwoJZnVuY3Rpb24gZGlzcGxheSgpIHsK
CQkkdGVtcGxhdGVNZ3IgPSAmVGVtcGxhdGVNYW5hZ2VyOjpnZXRNYW5hZ2VyKCk7CgkJJHNpdGUg
PSAmUmVxdWVzdDo6Z2V0U2l0ZSgpOwoJCSR0ZW1wbGF0ZU1nci0+YXNzaWduKCdhcnRpY2xlSWQn
LCAkdGhpcy0+YXJ0aWNsZUlkKTsKCgkJJHNpdGUgPSAmUmVxdWVzdDo6Z2V0U2l0ZSgpOwoJCSR0
ZW1wbGF0ZU1nci0+YXNzaWduKCdhdmFpbGFibGVMb2NhbGVzJywgJHNpdGUtPmdldFN1cHBvcnRl
ZExvY2FsZU5hbWVzKCkpOwoKCQkkY291bnRyeURhbyA9JiBEQU9SZWdpc3RyeTo6Z2V0REFPKCdD
b3VudHJ5REFPJyk7CgkJJGNvdW50cmllcyA9JiAkY291bnRyeURhby0+Z2V0Q291bnRyaWVzKCk7
CgkJJHRlbXBsYXRlTWdyLT5hc3NpZ25fYnlfcmVmKCdjb3VudHJpZXMnLCAkY291bnRyaWVzKTsK
CgkJcGFyZW50OjpkaXNwbGF5KCk7Cgl9CgoJLyoqCgkgKiBBc3NpZ24gZm9ybSBkYXRhIHRvIHVz
ZXItc3VibWl0dGVkIGRhdGEuCgkgKi8KCWZ1bmN0aW9uIHJlYWRJbnB1dERhdGEoKSB7CgkJJHRo
aXMtPnJlYWRVc2VyVmFycyhhcnJheSgKCQkJJ3NhbHV0YXRpb24nLAoJCQknZmlyc3ROYW1lJywK
CQkJJ21pZGRsZU5hbWUnLAoJCQknbGFzdE5hbWUnLAoJCQknZ2VuZGVyJywKCQkJJ2luaXRpYWxz
JywKCQkJJ2FmZmlsaWF0aW9uJywKCQkJJ2VtYWlsJywKCQkJJ3VzZXJVcmwnLAoJCQkncGhvbmUn
LAoJCQknZmF4JywKCQkJJ21haWxpbmdBZGRyZXNzJywKCQkJJ2NvdW50cnknLAoJCQknYmlvZ3Jh
cGh5JywKCQkJJ2ludGVyZXN0cycsCgkJCSd1c2VyTG9jYWxlcycsCgkJCSdzZW5kTm90aWZ5JywK
CQkJJ3VzZXJuYW1lJwoJCSkpOwoKCQlpZiAoJHRoaXMtPmdldERhdGEoJ3VzZXJMb2NhbGVzJykg
PT0gbnVsbCB8fCAhaXNfYXJyYXkoJHRoaXMtPmdldERhdGEoJ3VzZXJMb2NhbGVzJykpKSB7CgkJ
CSR0aGlzLT5zZXREYXRhKCd1c2VyTG9jYWxlcycsIGFycmF5KCkpOwoJCX0KCgkJaWYgKCR0aGlz
LT5nZXREYXRhKCd1c2VybmFtZScpICE9IG51bGwpIHsKCQkJLy8gVXNlcm5hbWVzIG11c3QgYmUg
bG93ZXJjYXNlCgkJCSR0aGlzLT5zZXREYXRhKCd1c2VybmFtZScsIHN0cnRvbG93ZXIoJHRoaXMt
PmdldERhdGEoJ3VzZXJuYW1lJykpKTsKCQl9Cgl9CgoJLyoqCgkgKiBSZWdpc3RlciBhIG5ldyB1
c2VyLgoJICogQHJldHVybiB1c2VySWQgaW50CgkgKi8KCWZ1bmN0aW9uIGV4ZWN1dGUoKSB7CgkJ
JHVzZXJEYW8gPSAmREFPUmVnaXN0cnk6OmdldERBTygnVXNlckRBTycpOwoJCSR1c2VyID0gJm5l
dyBVc2VyKCk7CgoJCSR1c2VyLT5zZXRTYWx1dGF0aW9uKCR0aGlzLT5nZXREYXRhKCdzYWx1dGF0
aW9uJykpOwoJCSR1c2VyLT5zZXRGaXJzdE5hbWUoJHRoaXMtPmdldERhdGEoJ2ZpcnN0TmFtZScp
KTsKCQkkdXNlci0+c2V0TWlkZGxlTmFtZSgkdGhpcy0+Z2V0RGF0YSgnbWlkZGxlTmFtZScpKTsK
CQkkdXNlci0+c2V0TGFzdE5hbWUoJHRoaXMtPmdldERhdGEoJ2xhc3ROYW1lJykpOwoJCSR1c2Vy
LT5zZXRHZW5kZXIoJHRoaXMtPmdldERhdGEoJ2dlbmRlcicpKTsKCQkkdXNlci0+c2V0SW5pdGlh
bHMoJHRoaXMtPmdldERhdGEoJ2luaXRpYWxzJykpOwoJCSR1c2VyLT5zZXRBZmZpbGlhdGlvbigk
dGhpcy0+Z2V0RGF0YSgnYWZmaWxpYXRpb24nKSk7CgkJJHVzZXItPnNldEVtYWlsKCR0aGlzLT5n
ZXREYXRhKCdlbWFpbCcpKTsKCQkkdXNlci0+c2V0VXJsKCR0aGlzLT5nZXREYXRhKCd1c2VyVXJs
JykpOwoJCSR1c2VyLT5zZXRQaG9uZSgkdGhpcy0+Z2V0RGF0YSgncGhvbmUnKSk7CgkJJHVzZXIt
PnNldEZheCgkdGhpcy0+Z2V0RGF0YSgnZmF4JykpOwoJCSR1c2VyLT5zZXRNYWlsaW5nQWRkcmVz
cygkdGhpcy0+Z2V0RGF0YSgnbWFpbGluZ0FkZHJlc3MnKSk7CgkJJHVzZXItPnNldENvdW50cnko
JHRoaXMtPmdldERhdGEoJ2NvdW50cnknKSk7CgkJJHVzZXItPnNldEJpb2dyYXBoeSgkdGhpcy0+
Z2V0RGF0YSgnYmlvZ3JhcGh5JyksIG51bGwpOyAvLyBMb2NhbGl6ZWQKCQkkdXNlci0+c2V0SW50
ZXJlc3RzKCR0aGlzLT5nZXREYXRhKCdpbnRlcmVzdHMnKSwgbnVsbCk7IC8vIExvY2FsaXplZAoJ
CSR1c2VyLT5zZXRNdXN0Q2hhbmdlUGFzc3dvcmQoJHRoaXMtPmdldERhdGEoJ211c3RDaGFuZ2VQ
YXNzd29yZCcpID8gMSA6IDApOwoKCQkkYXV0aERhbyA9ICZEQU9SZWdpc3RyeTo6Z2V0REFPKCdB
dXRoU291cmNlREFPJyk7CgkJJGF1dGggPSYgJGF1dGhEYW8tPmdldERlZmF1bHRQbHVnaW4oKTsK
CQkkdXNlci0+c2V0QXV0aElkKCRhdXRoPyRhdXRoLT5nZXRBdXRoSWQoKTowKTsKCgkJJHNpdGUg
PSAmUmVxdWVzdDo6Z2V0U2l0ZSgpOwoJCSRhdmFpbGFibGVMb2NhbGVzID0gJHNpdGUtPmdldFN1
cHBvcnRlZExvY2FsZXMoKTsKCgkJJGxvY2FsZXMgPSBhcnJheSgpOwoJCWZvcmVhY2ggKCR0aGlz
LT5nZXREYXRhKCd1c2VyTG9jYWxlcycpIGFzICRsb2NhbGUpIHsKCQkJaWYgKExvY2FsZTo6aXNM
b2NhbGVWYWxpZCgkbG9jYWxlKSAmJiBpbl9hcnJheSgkbG9jYWxlLCAkYXZhaWxhYmxlTG9jYWxl
cykpIHsKCQkJCWFycmF5X3B1c2goJGxvY2FsZXMsICRsb2NhbGUpOwoJCQl9CgkJfQoJCSR1c2Vy
LT5zZXRMb2NhbGVzKCRsb2NhbGVzKTsKCgkJJHVzZXItPnNldFVzZXJuYW1lKCR0aGlzLT5nZXRE
YXRhKCd1c2VybmFtZScpKTsKCQkkcGFzc3dvcmQgPSBWYWxpZGF0aW9uOjpnZW5lcmF0ZVBhc3N3
b3JkKCk7CgkJJHNlbmROb3RpZnkgPSAkdGhpcy0+Z2V0RGF0YSgnc2VuZE5vdGlmeScpOwoKCQlp
ZiAoaXNzZXQoJGF1dGgpKSB7CgkJCSR1c2VyLT5zZXRQYXNzd29yZCgkcGFzc3dvcmQpOwoJCQkv
LyBGSVhNRSBDaGVjayByZXN1bHQgYW5kIGhhbmRsZSBmYWlsdXJlcwoJCQkkYXV0aC0+ZG9DcmVh
dGVVc2VyKCR1c2VyKTsKCQkJJHVzZXItPnNldEF1dGhJZCgkYXV0aC0+YXV0aElkKTsKCQkJJHVz
ZXItPnNldFBhc3N3b3JkKFZhbGlkYXRpb246OmVuY3J5cHRDcmVkZW50aWFscygkdXNlci0+Z2V0
VXNlcklkKCksIFZhbGlkYXRpb246OmdlbmVyYXRlUGFzc3dvcmQoKSkpOyAvLyBVc2VkIGZvciBQ
VyByZXNldCBoYXNoIG9ubHkKCQl9IGVsc2UgewoJCQkkdXNlci0+c2V0UGFzc3dvcmQoVmFsaWRh
dGlvbjo6ZW5jcnlwdENyZWRlbnRpYWxzKCR0aGlzLT5nZXREYXRhKCd1c2VybmFtZScpLCAkcGFz
c3dvcmQpKTsKCQl9CgoJCSR1c2VyLT5zZXREYXRlUmVnaXN0ZXJlZChDb3JlOjpnZXRDdXJyZW50
RGF0ZSgpKTsKCQkkdXNlcklkID0gJHVzZXJEYW8tPmluc2VydFVzZXIoJHVzZXIpOwoKCQkkcm9s
ZURhbyA9ICZEQU9SZWdpc3RyeTo6Z2V0REFPKCdSb2xlREFPJyk7CgkJJGpvdXJuYWwgPSAmUmVx
dWVzdDo6Z2V0Sm91cm5hbCgpOwoJCSRyb2xlID0gJm5ldyBSb2xlKCk7CgkJJHJvbGUtPnNldEpv
dXJuYWxJZCgkam91cm5hbC0+Z2V0Sm91cm5hbElkKCkpOwoJCSRyb2xlLT5zZXRVc2VySWQoJHVz
ZXJJZCk7CgkJJHJvbGUtPnNldFJvbGVJZChST0xFX0lEX1JFVklFV0VSKTsKCQkkcm9sZURhby0+
aW5zZXJ0Um9sZSgkcm9sZSk7CgoJCWlmICgkc2VuZE5vdGlmeSkgewoJCQkvLyBTZW5kIHdlbGNv
bWUgZW1haWwgdG8gdXNlcgoJCQlpbXBvcnQoJ21haWwuTWFpbFRlbXBsYXRlJyk7CgkJCSRtYWls
ID0gJm5ldyBNYWlsVGVtcGxhdGUoJ1JFVklFV0VSX1JFR0lTVEVSJyk7CgkJCSRtYWlsLT5zZXRG
cm9tKCRqb3VybmFsLT5nZXRTZXR0aW5nKCdjb250YWN0RW1haWwnKSwgJGpvdXJuYWwtPmdldFNl
dHRpbmcoJ2NvbnRhY3ROYW1lJykpOwoJCQkkbWFpbC0+YXNzaWduUGFyYW1zKGFycmF5KCd1c2Vy
bmFtZScgPT4gJHRoaXMtPmdldERhdGEoJ3VzZXJuYW1lJyksICdwYXNzd29yZCcgPT4gJHBhc3N3
b3JkLCAndXNlckZ1bGxOYW1lJyA9PiAkdXNlci0+Z2V0RnVsbE5hbWUoKSkpOwoJCQkkbWFpbC0+
YWRkUmVjaXBpZW50KCR1c2VyLT5nZXRFbWFpbCgpLCAkdXNlci0+Z2V0RnVsbE5hbWUoKSk7CgkJ
CSRtYWlsLT5zZW5kKCk7CgkJfQoKCQlyZXR1cm4gJHVzZXJJZDsKCX0KfQoKPz4K
</data>

          </attachment>
      

    </bug>

</bugzilla>