3166 2007-12-02 09:57:00 -0800 Allow multiple PayPal payment attempts 2008-04-28 09:50:13 -0700 1 1 1 Unclassified OCS General 2.1 PC Linux RESOLVED FIXED P1 normal --- 1 alec pkp-support 9695 alec 2007-12-02 09:57:47 -0800 Allow multiple PayPal payment attempts; see the second part of <http://pkp.sfu.ca/support/forum/viewtopic.php?f=3&t=2478>. Some users will not follow through on the first attempt. 9985 485 alec 2008-01-31 11:23:49 -0800 Created attachment 485 Patch against OCS pre-2.1 CVS 9986 alec 2008-01-31 11:24:21 -0800 Fixed. Further requests for the registration page for registrants with pending payments will be redirected to the payment page. 10238 jmacgreg 2008-03-26 17:57:35 -0700 Response to the patch, from the same support thread: "We need the user to be able to go back and change the category they registered for. That is, go back to the registration form. A couple of different scenarios need to covered here: 1. If somebody registers before the end of early registration (ie. discounted) and then doesn't pay, for whatever reason, and comes back after the end of the discounted period and wants to pay. They would need to be redirected back to select a registration category that was still active. 2. Say someone accidentally chose the wrong registration category, or simply changed their mind. They would also need to be able to go back to the registration form." I can take a look at this patch functionality and suggest refinements in line with what Trudy's suggesting if you'd like, Alec. I'm in the midst of writing up some payments documentation, so by rights I should have a good idea on what's going on here. 10433 alec 2008-04-17 10:01:56 -0700 Reopening in light of comment #3. 10576 596 juan 2008-04-27 19:56:13 -0700 Created attachment 596 Patch against CVS version: including patch 485 This patch solves the issues addressed in comment #3 by not redirecting back to the paypal screen, but rather, by redirecting back to the registration screen. This method seems to work, at least in how I envision the workflow. However, someone more familiar with OCS users could disagree. One thing this patch does not do is allow users to change the registration type once they have already paid. 485 2008-01-31 11:23:00 -0800 2008-01-31 11:23:49 -0800 Patch against OCS pre-2.1 CVS 3166.diff text/plain 2133 alec ZGlmZiAtdSAtcjEuMzAgU2NoZWRDb25mSGFuZGxlci5pbmMucGhwCi0tLSBwYWdlcy9zY2hlZENv bmYvU2NoZWRDb25mSGFuZGxlci5pbmMucGhwCTMwIEphbiAyMDA4IDIxOjA5OjEwIC0wMDAwCTEu MzAKKysrIHBhZ2VzL3NjaGVkQ29uZi9TY2hlZENvbmZIYW5kbGVyLmluYy5waHAJMzEgSmFuIDIw MDggMTk6MjI6MDIgLTAwMDAKQEAgLTE1MywxMiArMTUzLDI1IEBACiAJCQkvLyBUaGlzIHVzZXIg aGFzIGFscmVhZHkgcmVnaXN0ZXJlZC4KIAkJCSRyZWdpc3RyYXRpb24gPSYgJHJlZ2lzdHJhdGlv bkRhby0+Z2V0UmVnaXN0cmF0aW9uKCRyZWdpc3RyYXRpb25JZCk7CiAKLQkJCWlmICgkcmVnaXN0 cmF0aW9uICYmICRyZWdpc3RyYXRpb24tPmdldERhdGVQYWlkKCkpICR0ZW1wbGF0ZU1nci0+YXNz aWduKCdtZXNzYWdlJywgJ3NjaGVkQ29uZi5yZWdpc3RyYXRpb24uYWxyZWFkeVJlZ2lzdGVyZWRB bmRQYWlkJyk7Ci0JCQllbHNlICR0ZW1wbGF0ZU1nci0+YXNzaWduKCdtZXNzYWdlJywgJ3NjaGVk Q29uZi5yZWdpc3RyYXRpb24uYWxyZWFkeVJlZ2lzdGVyZWQnKTsKKwkJCWltcG9ydCgncGF5bWVu dC5vY3MuT0NTUGF5bWVudE1hbmFnZXInKTsKKwkJCSRwYXltZW50TWFuYWdlciA9JiBPQ1NQYXlt ZW50TWFuYWdlcjo6Z2V0TWFuYWdlcigpOwogCi0JCQkkdGVtcGxhdGVNZ3ItPmFzc2lnbignYmFj a0xpbmtMYWJlbCcsICdjb21tb24uYmFjaycpOwotCQkJJHRlbXBsYXRlTWdyLT5hc3NpZ24oJ2Jh Y2tMaW5rJywgUmVxdWVzdDo6dXJsKG51bGwsIG51bGwsICdpbmRleCcpKTsKLQkJCSR0ZW1wbGF0 ZU1nci0+ZGlzcGxheSgnY29tbW9uL21lc3NhZ2UudHBsJyk7CisJCQlpZiAoISRwYXltZW50TWFu YWdlci0+aXNDb25maWd1cmVkKCkgfHwgISRyZWdpc3RyYXRpb24gfHwgJHJlZ2lzdHJhdGlvbi0+ Z2V0RGF0ZVBhaWQoKSkgeworCQkJCS8vIElmIHRoZSBzeXN0ZW0gaXNuJ3QgZnVsbHkgY29uZmln dXJlZCBvciB0aGUgcmVnaXN0cmF0aW9uIGlzIGFscmVhZHkgcGFpZCwKKwkJCQkvLyBkaXNwbGF5 IGEgbWVzc2FnZSBhbmQgYmxvY2sgdGhlIHVzZXIgZnJvbSBnb2luZyBmdXJ0aGVyLgorCQkJCSR0 ZW1wbGF0ZU1nci0+YXNzaWduKCdtZXNzYWdlJywgJ3NjaGVkQ29uZi5yZWdpc3RyYXRpb24uYWxy ZWFkeVJlZ2lzdGVyZWRBbmRQYWlkJyk7CisJCQkJJHRlbXBsYXRlTWdyLT5hc3NpZ24oJ2JhY2tM aW5rTGFiZWwnLCAnY29tbW9uLmJhY2snKTsKKwkJCQkkdGVtcGxhdGVNZ3ItPmFzc2lnbignYmFj a0xpbmsnLCBSZXF1ZXN0Ojp1cmwobnVsbCwgbnVsbCwgJ2luZGV4JykpOworCQkJCXJldHVybiAk dGVtcGxhdGVNZ3ItPmRpc3BsYXkoJ2NvbW1vbi9tZXNzYWdlLnRwbCcpOworCQkJfSBlbHNlIHsK KwkJCQkvLyBPdGhlcndpc2UsIGFsbG93IHRoZW0gdG8gdHJ5IHRvIHBheSBhZ2Fpbi4KKwkJCQkk cmVnaXN0cmF0aW9uVHlwZURhbyA9JiBEQU9SZWdpc3RyeTo6Z2V0REFPKCdSZWdpc3RyYXRpb25U eXBlREFPJyk7CisJCQkJJHJlZ2lzdHJhdGlvblR5cGUgPSYgJHJlZ2lzdHJhdGlvblR5cGVEYW8t PmdldFJlZ2lzdHJhdGlvblR5cGUoJHJlZ2lzdHJhdGlvbi0+Z2V0VHlwZUlkKCkpOworCQkJCSRx dWV1ZWRQYXltZW50ID0mICRwYXltZW50TWFuYWdlci0+Y3JlYXRlUXVldWVkUGF5bWVudCgkc2No ZWRDb25mLT5nZXRDb25mZXJlbmNlSWQoKSwgJHNjaGVkQ29uZi0+Z2V0U2NoZWRDb25mSWQoKSwg UVVFVUVEX1BBWU1FTlRfVFlQRV9SRUdJU1RSQVRJT04sICR1c2VyLT5nZXRVc2VySWQoKSwgJHJl Z2lzdHJhdGlvbklkLCAkcmVnaXN0cmF0aW9uVHlwZS0+Z2V0Q29zdCgpLCAkcmVnaXN0cmF0aW9u VHlwZS0+Z2V0Q3VycmVuY3lDb2RlQWxwaGEoKSk7CisJCQkJJHF1ZXVlZFBheW1lbnRJZCA9ICRw YXltZW50TWFuYWdlci0+cXVldWVQYXltZW50KCRxdWV1ZWRQYXltZW50LCB0aW1lKCkgKyAoNjAg KiA2MCAqIDI0ICogMzApKTsgLy8gMzAgZGF5cyB0byBjb21wbGV0ZQorCisJCQkJJHBheW1lbnRN YW5hZ2VyLT5kaXNwbGF5UGF5bWVudEZvcm0oJHF1ZXVlZFBheW1lbnRJZCwgJHF1ZXVlZFBheW1l bnQpOworCQkJfQogCQl9IGVsc2UgewogCQkJaW1wb3J0KCdyZWdpc3RyYXRpb24uZm9ybS5Vc2Vy UmVnaXN0cmF0aW9uRm9ybScpOwogCiAK 596 2008-04-27 19:56:00 -0700 2008-04-27 19:56:13 -0700 Patch against CVS version: including patch 485 bug3166.patch text/plain 2862 juan IyMjIEVjbGlwc2UgV29ya3NwYWNlIFBhdGNoIDEuMAojUCBvY3NjdnMKSW5kZXg6IHBhZ2VzL3Nj aGVkQ29uZi9TY2hlZENvbmZIYW5kbGVyLmluYy5waHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQpSQ1MgZmlsZTogL2N2 cy9vY3MyL3BhZ2VzL3NjaGVkQ29uZi9TY2hlZENvbmZIYW5kbGVyLmluYy5waHAsdgpyZXRyaWV2 aW5nIHJldmlzaW9uIDEuMzYKZGlmZiAtdSAtcjEuMzYgU2NoZWRDb25mSGFuZGxlci5pbmMucGhw Ci0tLSBwYWdlcy9zY2hlZENvbmYvU2NoZWRDb25mSGFuZGxlci5pbmMucGhwCTExIEFwciAyMDA4 IDA2OjQxOjIwIC0wMDAwCTEuMzYKKysrIHBhZ2VzL3NjaGVkQ29uZi9TY2hlZENvbmZIYW5kbGVy LmluYy5waHAJMjggQXByIDIwMDggMDI6NDg6MzQgLTAwMDAKQEAgLTE3NSwyNiArMTc1LDE4IEBA CiAJCQkJJHRlbXBsYXRlTWdyLT5hc3NpZ24oJ2JhY2tMaW5rTGFiZWwnLCAnY29tbW9uLmJhY2sn KTsKIAkJCQkkdGVtcGxhdGVNZ3ItPmFzc2lnbignYmFja0xpbmsnLCBSZXF1ZXN0Ojp1cmwobnVs bCwgbnVsbCwgJ2luZGV4JykpOwogCQkJCXJldHVybiAkdGVtcGxhdGVNZ3ItPmRpc3BsYXkoJ2Nv bW1vbi9tZXNzYWdlLnRwbCcpOwotCQkJfSBlbHNlIHsKLQkJCQkvLyBPdGhlcndpc2UsIGFsbG93 IHRoZW0gdG8gdHJ5IHRvIHBheSBhZ2Fpbi4KLQkJCQkkcmVnaXN0cmF0aW9uVHlwZURhbyA9JiBE QU9SZWdpc3RyeTo6Z2V0REFPKCdSZWdpc3RyYXRpb25UeXBlREFPJyk7Ci0JCQkJJHJlZ2lzdHJh dGlvblR5cGUgPSYgJHJlZ2lzdHJhdGlvblR5cGVEYW8tPmdldFJlZ2lzdHJhdGlvblR5cGUoJHJl Z2lzdHJhdGlvbi0+Z2V0VHlwZUlkKCkpOwotCQkJCSRxdWV1ZWRQYXltZW50ID0mICRwYXltZW50 TWFuYWdlci0+Y3JlYXRlUXVldWVkUGF5bWVudCgkc2NoZWRDb25mLT5nZXRDb25mZXJlbmNlSWQo KSwgJHNjaGVkQ29uZi0+Z2V0U2NoZWRDb25mSWQoKSwgUVVFVUVEX1BBWU1FTlRfVFlQRV9SRUdJ U1RSQVRJT04sICR1c2VyLT5nZXRVc2VySWQoKSwgJHJlZ2lzdHJhdGlvbklkLCAkcmVnaXN0cmF0 aW9uVHlwZS0+Z2V0Q29zdCgpLCAkcmVnaXN0cmF0aW9uVHlwZS0+Z2V0Q3VycmVuY3lDb2RlQWxw aGEoKSk7Ci0JCQkJJHF1ZXVlZFBheW1lbnRJZCA9ICRwYXltZW50TWFuYWdlci0+cXVldWVQYXlt ZW50KCRxdWV1ZWRQYXltZW50LCB0aW1lKCkgKyAoNjAgKiA2MCAqIDI0ICogMzApKTsgLy8gMzAg ZGF5cyB0byBjb21wbGV0ZQotCi0JCQkJJHBheW1lbnRNYW5hZ2VyLT5kaXNwbGF5UGF5bWVudEZv cm0oJHF1ZXVlZFBheW1lbnRJZCwgJHF1ZXVlZFBheW1lbnQpOwogCQkJfQotCQl9IGVsc2Ugewot CQkJaW1wb3J0KCdyZWdpc3RyYXRpb24uZm9ybS5Vc2VyUmVnaXN0cmF0aW9uRm9ybScpOworCQl9 CiAKLQkJCSRmb3JtID0mIG5ldyBVc2VyUmVnaXN0cmF0aW9uRm9ybSgpOwotCQkJaWYgKCRmb3Jt LT5pc0xvY2FsZVJlc3VibWl0KCkpIHsKLQkJCQkkZm9ybS0+cmVhZElucHV0RGF0YSgpOwotCQkJ fSBlbHNlIHsKLQkJCQkkZm9ybS0+aW5pdERhdGEoKTsKLQkJCX0KLQkJCSRmb3JtLT5kaXNwbGF5 KCk7CisJCWltcG9ydCgncmVnaXN0cmF0aW9uLmZvcm0uVXNlclJlZ2lzdHJhdGlvbkZvcm0nKTsK KworCQkkZm9ybSA9JiBuZXcgVXNlclJlZ2lzdHJhdGlvbkZvcm0oKTsKKwkJaWYgKCRmb3JtLT5p c0xvY2FsZVJlc3VibWl0KCkpIHsKKwkJCSRmb3JtLT5yZWFkSW5wdXREYXRhKCk7CisJCX0gZWxz ZSB7CisJCQkkZm9ybS0+aW5pdERhdGEoKTsKIAkJfQorCQkkZm9ybS0+ZGlzcGxheSgpOwogCX0K IAogCS8qKgpAQCAtMjA5LDEwICsyMDEsMTcgQEAKIAkJJHVzZXIgPSYgUmVxdWVzdDo6Z2V0VXNl cigpOwogCQkkcmVnaXN0cmF0aW9uRGFvID0mIERBT1JlZ2lzdHJ5OjpnZXREQU8oJ1JlZ2lzdHJh dGlvbkRBTycpOwogCQlpZiAoJHVzZXIgJiYgKCRyZWdpc3RyYXRpb25JZCA9ICRyZWdpc3RyYXRp b25EYW8tPmdldFJlZ2lzdHJhdGlvbklkQnlVc2VyKCR1c2VyLT5nZXRVc2VySWQoKSwgJHNjaGVk Q29uZi0+Z2V0U2NoZWRDb25mSWQoKSkpKSB7Ci0JCQkvLyBVc2VyIGlzIGFscmVhZHkgcmVnaXN0 ZXJlZC4gUmVkaXJlY3QgdG8gYSBtZXNzYWdlIGV4cGxhaW5pbmcuCi0JCQlSZXF1ZXN0OjpyZWRp cmVjdChudWxsLCBudWxsLCBudWxsLCAncmVnaXN0cmF0aW9uJyk7CisJCQkvLyBUaGlzIHVzZXIg aGFzIGFscmVhZHkgcmVnaXN0ZXJlZC4KKwkJCSRyZWdpc3RyYXRpb24gPSYgJHJlZ2lzdHJhdGlv bkRhby0+Z2V0UmVnaXN0cmF0aW9uKCRyZWdpc3RyYXRpb25JZCk7CisJCQlpZiAoICEkcmVnaXN0 cmF0aW9uIHx8ICRyZWdpc3RyYXRpb24tPmdldERhdGVQYWlkKCkgKSB7CisJCQkJLy8gQW5kIHRo ZXkgaGF2ZSBhbHJlYWR5IHBhaWQuIFJlZGlyZWN0IHRvIGEgbWVzc2FnZSBleHBsYWluaW5nLgor CQkJCVJlcXVlc3Q6OnJlZGlyZWN0KG51bGwsIG51bGwsIG51bGwsICdyZWdpc3RyYXRpb24nKTsK KwkJCX0gZWxzZSB7CisJCQkJLy8gQWxsb3cgdGhlbSB0byByZXN1Ym1pdCB0aGUgZm9ybSB0byBj aGFuZ2UgdHlwZSBvciBwYXkgYWdhaW4uCisJCQkJJHJlZ2lzdHJhdGlvbkRhby0+ZGVsZXRlUmVn aXN0cmF0aW9uQnlJZCgkcmVnaXN0cmF0aW9uSWQpOworCQkJfQkJCQogCQl9Ci0KKwkJCiAJCSR0 ZW1wbGF0ZU1nciA9JiBUZW1wbGF0ZU1hbmFnZXI6OmdldE1hbmFnZXIoKTsKIAkJJHRlbXBsYXRl TWdyLT5hc3NpZ24oJ3BhZ2VIaWVyYXJjaHknLCBhcnJheSgKIAkJCWFycmF5KFJlcXVlc3Q6OnVy bChudWxsLCAnaW5kZXgnLCAnaW5kZXgnKSwgJGNvbmZlcmVuY2UtPmdldENvbmZlcmVuY2VUaXRs ZSgpLCB0cnVlKSwK