We are moving to Git Issues for bug tracking in future releases. During transition, content will be in both tools. If you'd like to file a new bug, please create an issue.

View | Details | Raw Unified | Return to bug 7714
Collapse All | Expand All

(-)a/classes/submission/trackDirector/TrackDirectorAction.inc.php (-4 / +5 lines)
 Lines 1659-1666   import('classes.file.PaperFileManager'); Link Here 
1659
	/**
1659
	/**
1660
	 * Accepts the review assignment on behalf of its reviewer.
1660
	 * Accepts the review assignment on behalf of its reviewer.
1661
	 * @param $reviewId int
1661
	 * @param $reviewId int
1662
	 * @param $accept boolean
1662
	 */
1663
	 */
1663
	function confirmReviewForReviewer($reviewId) {
1664
	function confirmReviewForReviewer($reviewId, $accept) {
1664
		$reviewAssignmentDao =& DAORegistry::getDAO('ReviewAssignmentDAO');
1665
		$reviewAssignmentDao =& DAORegistry::getDAO('ReviewAssignmentDAO');
1665
		$userDao =& DAORegistry::getDAO('UserDAO');
1666
		$userDao =& DAORegistry::getDAO('UserDAO');
1666
		$user =& Request::getUser();
1667
		$user =& Request::getUser();
 Lines 1668-1679   import('classes.file.PaperFileManager'); Link Here 
1668
		$reviewAssignment =& $reviewAssignmentDao->getById($reviewId);
1669
		$reviewAssignment =& $reviewAssignmentDao->getById($reviewId);
1669
		$reviewer =& $userDao->getUser($reviewAssignment->getReviewerId(), true);
1670
		$reviewer =& $userDao->getUser($reviewAssignment->getReviewerId(), true);
1670
1671
1671
		if (HookRegistry::call('TrackDirectorAction::confirmReviewForReviewer', array(&$reviewAssignment, &$reviewer))) return;
1672
		if (HookRegistry::call('TrackDirectorAction::confirmReviewForReviewer', array(&$reviewAssignment, &$reviewer, &$accept))) return;
1672
1673
1673
		// Only confirm the review for the reviewer if
1674
		// Only confirm the review for the reviewer if
1674
		// he has not previously done so.
1675
		// he has not previously done so.
1675
		if ($reviewAssignment->getDateConfirmed() == null) {
1676
		if ($reviewAssignment->getDateConfirmed() == null) {
1676
			$reviewAssignment->setDeclined(0);
1677
			$reviewAssignment->setDeclined($accept?0:1);
1677
			$reviewAssignment->setDateConfirmed(Core::getCurrentDate());
1678
			$reviewAssignment->setDateConfirmed(Core::getCurrentDate());
1678
			$reviewAssignment->stampModified();
1679
			$reviewAssignment->stampModified();
1679
			$reviewAssignmentDao->updateReviewAssignment($reviewAssignment);
1680
			$reviewAssignmentDao->updateReviewAssignment($reviewAssignment);
 Lines 1687-1693   import('classes.file.PaperFileManager'); Link Here 
1687
			$entry->setUserId($user->getId());
1688
			$entry->setUserId($user->getId());
1688
			$entry->setDateLogged(Core::getCurrentDate());
1689
			$entry->setDateLogged(Core::getCurrentDate());
1689
			$entry->setEventType(PAPER_LOG_REVIEW_ACCEPT_BY_PROXY);
1690
			$entry->setEventType(PAPER_LOG_REVIEW_ACCEPT_BY_PROXY);
1690
			$entry->setLogMessage('log.review.reviewAcceptedByProxy', array('reviewerName' => $reviewer->getFullName(), 'paperId' => $reviewAssignment->getSubmissionId(), 'stage' => $reviewAssignment->getRound(), 'userName' => $user->getFullName()));
1691
			$entry->setLogMessage($accept?'log.review.reviewAcceptedByProxy':'log.review.reviewDeclinedByProxy', array('reviewerName' => $reviewer->getFullName(), 'paperId' => $reviewAssignment->getSubmissionId(), 'stage' => $reviewAssignment->getRound(), 'userName' => $user->getFullName()));
1691
			$entry->setAssocType(LOG_TYPE_REVIEW);
1692
			$entry->setAssocType(LOG_TYPE_REVIEW);
1692
			$entry->setAssocId($reviewAssignment->getId());
1693
			$entry->setAssocId($reviewAssignment->getId());
1693
1694
(-)a/locale/en_US/locale.xml (+1 lines)
 Lines 781-786   Your server currently supports mbstring: <strong>{$supportsMBString}</strong>]]> Link Here 
781
	<message key="log.review.reviewDeclined">{$reviewerName} has declined the stage {$stage} review for submission {$paperId}.</message>
781
	<message key="log.review.reviewDeclined">{$reviewerName} has declined the stage {$stage} review for submission {$paperId}.</message>
782
	<message key="log.review.reviewAccepted">{$reviewerName} has accepted the stage {$stage} review for submission {$paperId}.</message>
782
	<message key="log.review.reviewAccepted">{$reviewerName} has accepted the stage {$stage} review for submission {$paperId}.</message>
783
	<message key="log.review.reviewAcceptedByProxy">{$userName} has accepted the stage {$stage} review for submission {$paperId} on behalf of {$reviewerName}.</message>
783
	<message key="log.review.reviewAcceptedByProxy">{$userName} has accepted the stage {$stage} review for submission {$paperId} on behalf of {$reviewerName}.</message>
784
	<message key="log.review.reviewDeclinedByProxy">{$userName} has declined the stage {$stage} review for submission {$paperId} on behalf of {$reviewerName}.</message>
784
	<message key="log.review.reviewFileByProxy">The Director, {$userName}, has uploaded a review file for stage {$stage} of submission {$paperId} on behalf of the reviewer, {$reviewerName}.</message>
785
	<message key="log.review.reviewFileByProxy">The Director, {$userName}, has uploaded a review file for stage {$stage} of submission {$paperId} on behalf of the reviewer, {$reviewerName}.</message>
785
	<message key="log.review.reviewerFile">A reviewer file has been uploaded.</message>
786
	<message key="log.review.reviewerFile">A reviewer file has been uploaded.</message>
786
	<message key="log.director.decision">A director decision ({$decision}) for paper {$paperId} was recorded by {$directorName}.</message>
787
	<message key="log.director.decision">A director decision ({$decision}) for paper {$paperId} was recorded by {$directorName}.</message>
(-)a/pages/trackDirector/SubmissionEditHandler.inc.php (-1 / +1 lines)
 Lines 752-758   class SubmissionEditHandler extends TrackDirectorHandler { Link Here 
752
		$schedConf =& $request->getSchedConf();
752
		$schedConf =& $request->getSchedConf();
753
		$submission =& $this->submission;
753
		$submission =& $this->submission;
754
754
755
		TrackDirectorAction::confirmReviewForReviewer($reviewId);
755
		TrackDirectorAction::confirmReviewForReviewer($reviewId, $accept);
756
		$request->redirect(null, null, null, 'submissionReview', $paperId);
756
		$request->redirect(null, null, null, 'submissionReview', $paperId);
757
	}
757
	}
758
758

Return to bug 7714