Attachment #2646 for bug #4913




	 * Records a director's submission decision.
	 * @param $trackDirectorSubmission object
	 * @param $decision int
	 * @param $stage int
	 */
	function recordDecision($trackDirectorSubmission, $decision, $stage) {
		$editAssignments =& $trackDirectorSubmission->getEditAssignments();
		if (empty($editAssignments)) return;


				$trackDirectorSubmission->stampStatusModified();
			}

			$trackDirectorSubmission->addDecision($directorDecision, $stage);
			$decisions = TrackDirectorSubmission::getDirectorDecisionOptions();
			// Add log
			import('paper.log.PaperLog');
			import('paper.log.PaperEventLogEntry');
			Locale::requireComponents(array(LOCALE_COMPONENT_APPLICATION_COMMON, LOCALE_COMPONENT_OCS_DIRECTOR));
			PaperLog::logEvent(
				$trackDirectorSubmission->getPaperId(),
				PAPER_LOG_DIRECTOR_DECISION,
				LOG_TYPE_DIRECTOR,
				$user->getId(),
				'log.director.decision',
				array(
					'directorName' => $user->getFullName(),
					'paperId' => $trackDirectorSubmission->getPaperId(),
					'decision' => Locale::translate($decisions[$decision]),
					'round' => ($stage == REVIEW_STAGE_ABSTRACT?'submission.abstractReview':'submission.paperReview')
				)
			);
		}

		if($decision == SUBMISSION_DIRECTOR_DECISION_ACCEPT || $decision == SUBMISSION_DIRECTOR_DECISION_INVITE) {

(-)classes/submission/trackDirector/TrackDirectorSubmissionDAO.inc.php (-1 / +1 lines)

Lines 162-168	Link Here

162

163

164

		// Update director decisions; hacked necessarily to iterate by reference.

164

		// Update director decisions; hacked necessarily to iterate by reference.

165

		for ($i = 1; $i <= $trackDirectorSubmission->getCurrentStage(); $i++) {

165

		foreach (array(REVIEW_STAGE_ABSTRACT, REVIEW_STAGE_PRESENTATION) as $i) {

166

			$directorDecisions = $trackDirectorSubmission->getDecisions($i);

166

			$directorDecisions = $trackDirectorSubmission->getDecisions($i);

167

			$insertedDecision = false;

167

			$insertedDecision = false;

168

			if (is_array($directorDecisions)) {

168

			if (is_array($directorDecisions)) {

(-)pages/author/TrackSubmissionHandler.inc.php (-5 / +8 lines)

Lines 115-122	Link Here

115

		$controlledVocabDao =& DAORegistry::getDAO('ControlledVocabDAO');

115

		$controlledVocabDao =& DAORegistry::getDAO('ControlledVocabDAO');

116

		$templateMgr->assign('sessionTypes', $controlledVocabDao->enumerateBySymbolic('sessionTypes', ASSOC_TYPE_SCHED_CONF, $schedConf->getId()));

116

		$templateMgr->assign('sessionTypes', $controlledVocabDao->enumerateBySymbolic('sessionTypes', ASSOC_TYPE_SCHED_CONF, $schedConf->getId()));

117

118

		import('submission.trackDirector.TrackDirectorSubmission');

118

		// FIXME: Author code should not use track director object

119

		$templateMgr->assign_by_ref('directorDecisionOptions', TrackDirectorSubmission::getDirectorDecisionOptions());

119

		$trackDirectorSubmissionDao =& DAORegistry::getDAO('TrackDirectorSubmissionDAO');

120

		$trackDirectorSubmission =& $trackDirectorSubmissionDao->getTrackDirectorSubmission($submission->getPaperId());

121

		$templateMgr->assign_by_ref('directorDecisionOptions', $trackDirectorSubmission->getDirectorDecisionOptions());

120

122

121

		$templateMgr->assign('helpTopicId','editorial.authorsRole');

123

		$templateMgr->assign('helpTopicId','editorial.authorsRole');

122

		$templateMgr->display('author/submission.tpl');

124

		$templateMgr->display('author/submission.tpl');

Lines 172-180	Link Here

172

		$templateMgr->assign_by_ref('suppFiles', $authorSubmission->getSuppFiles());

174

		$templateMgr->assign_by_ref('suppFiles', $authorSubmission->getSuppFiles());

173

		$templateMgr->assign('lastDirectorDecision', $lastDecision);

175

		$templateMgr->assign('lastDirectorDecision', $lastDecision);

174

176

175

		// Bring in director decision options

177

		// FIXME: Author code should not use track director object

176

		import('submission.trackDirector.TrackDirectorSubmission');

178

		$trackDirectorSubmissionDao =& DAORegistry::getDAO('TrackDirectorSubmissionDAO');

177

		$templateMgr->assign_by_ref('directorDecisionOptions', TrackDirectorSubmission::getDirectorDecisionOptions());

179

		$trackDirectorSubmission =& $trackDirectorSubmissionDao->getTrackDirectorSubmission($authorSubmission->getPaperId());

180

		$templateMgr->assign_by_ref('directorDecisionOptions', $trackDirectorSubmission->getDirectorDecisionOptions());

178

181

179

		// Determine whether or not certain features should be disabled (i.e. past deadline)

182

		// Determine whether or not certain features should be disabled (i.e. past deadline)

180

		$templateMgr->assign('mayEditPaper', AuthorAction::mayEditPaper($authorSubmission));

183

		$templateMgr->assign('mayEditPaper', AuthorAction::mayEditPaper($authorSubmission));




		Request::redirect(null, null, null, 'submission', $paperId);
	}

	function recordDecision($args) {
		$paperId = (int) Request::getUserVar('paperId');
		$decision = (int) Request::getUserVar('decision');
		$stage = (int) array_shift($args);

		$this->validate($paperId, TRACK_DIRECTOR_ACCESS_REVIEW);
		$conference =& Request::getConference();
		$schedConf =& Request::getSchedConf();
		$submission =& $this->submission;

		// If the director changes the decision on the first round,
		// roll back to the abstract review stage.
		if (
			$submission->getCurrentStage() == REVIEW_STAGE_PRESENTATION &&
			$stage == REVIEW_STAGE_ABSTRACT
		) {
				($decision == SUBMISSION_DIRECTOR_DECISION_PENDING_REVISIONS || $decision == SUBMISSION_DIRECTOR_DECISION_DECLINE)) {
			$submission->setCurrentStage(REVIEW_STAGE_PRESENTATION);
			$submission->setSubmissionProgress(2);
			$stage = REVIEW_STAGE_PRESENTATION;

			TrackDirectorAction::recordDecision($submission, $decision);
		} else if($submission->getCurrentStage() == REVIEW_STAGE_ABSTRACT &&
				($decision == SUBMISSION_DIRECTOR_DECISION_PENDING_REVISIONS || $decision == SUBMISSION_DIRECTOR_DECISION_DECLINE)) {
			$submission->setCurrentStage(REVIEW_STAGE_ABSTRACT);
			$submission->setSubmissionProgress(3);
			$stage = REVIEW_STAGE_ABSTRACT;

			// Now, unassign all reviewers from the paper review
			foreach ($submission->getReviewAssignments(REVIEW_STAGE_PRESENTATION) as $reviewAssignment) {

				}
			}

			TrackDirectorAction::recordDecision($submission, $decision, $stage);
		} else {
			switch ($decision) {
				case SUBMISSION_DIRECTOR_DECISION_ACCEPT:
				case SUBMISSION_DIRECTOR_DECISION_INVITE:
				case SUBMISSION_DIRECTOR_DECISION_PENDING_REVISIONS:
				case SUBMISSION_DIRECTOR_DECISION_DECLINE:
					TrackDirectorAction::recordDecision($submission, $decision, $stage);
					break;
			}
		}

(-)templates/trackDirector/submission/directorDecision.tpl (-1 / +1 lines)

Lines 15-21	Link Here

<tr valign="top">

<tr valign="top">

	<td class="label" width="20%">{translate key="director.paper.selectDecision"}</td>

	<td class="label" width="20%">{translate key="director.paper.selectDecision"}</td>

	<td width="80%" class="value" colspan="2">

	<td width="80%" class="value" colspan="2">

		<form method="post" action="{url op="recordDecision"}">

		<form method="post" action="{url op="recordDecision" path=$stage}">

			<input type="hidden" name="paperId" value="{$submission->getPaperId()}" />

			<input type="hidden" name="paperId" value="{$submission->getPaperId()}" />

			<select name="decision" size="1" class="selectMenu"{if not $allowRecommendation} disabled="disabled"{/if}>

			<select name="decision" size="1" class="selectMenu"{if not $allowRecommendation} disabled="disabled"{/if}>

				{assign var=availableDirectorDecisionOptions value=`$submission->getDirectorDecisionOptions($currentSchedConf,$stage)`}

				{assign var=availableDirectorDecisionOptions value=`$submission->getDirectorDecisionOptions($currentSchedConf,$stage)`}

Return to bug 4913