Attachment #2645 for bug #4913




	 * Records a director's submission decision.
	 * @param $trackDirectorSubmission object
	 * @param $decision int
	 * @param $round int
	 */
	function recordDecision($trackDirectorSubmission, $decision, $round) {
		$editAssignments =& $trackDirectorSubmission->getEditAssignments();
		if (empty($editAssignments)) return;

		$trackDirectorSubmissionDao =& DAORegistry::getDAO('TrackDirectorSubmissionDAO');
		$user =& Request::getUser();
		$directorDecision = array(
			'editDecisionId' => null,
			'directorId' => $user->getUserId(),

			'dateDecided' => date(Core::getCurrentDate())
		);

		if (!HookRegistry::call('TrackDirectorAction::recordDecision', array(&$trackDirectorSubmission, $directorDecision, $round))) {
			if ($decision == SUBMISSION_DIRECTOR_DECISION_DECLINE) {
				$trackDirectorSubmission->setStatus(SUBMISSION_STATUS_DECLINED);
				$trackDirectorSubmission->stampStatusModified();

				$trackDirectorSubmission->stampStatusModified();
			}

			$trackDirectorSubmission->addDecision($directorDecision, $round);
			$schedConf =& Request::getSchedConf();
			$decisions = $trackDirectorSubmission->getDirectorDecisionOptions();

			// Add log
			import('paper.log.PaperLog');
			import('paper.log.PaperEventLogEntry');
			PaperLog::logEvent(
				$trackDirectorSubmission->getPaperId(),
				PAPER_LOG_DIRECTOR_DECISION,
				LOG_TYPE_DIRECTOR,
				$user->getUserId(),
				'log.director.decision',
				array(
					'directorName' => $user->getFullName(),
					'paperId' => $trackDirectorSubmission->getPaperId(),
					'decision' => Locale::translate($decisions[$decision]),
					'round' => ($round == REVIEW_STAGE_ABSTRACT?'submission.abstractReview':'submission.paperReview')
				)
			);
		}

		if($decision == SUBMISSION_DIRECTOR_DECISION_ACCEPT || $decision == SUBMISSION_DIRECTOR_DECISION_INVITE) {

(-)classes/submission/trackDirector/TrackDirectorSubmissionDAO.inc.php (-1 / +1 lines)

Lines 162-168	Link Here

162

163

164

		// Update director decisions; hacked necessarily to iterate by reference.

164

		// Update director decisions; hacked necessarily to iterate by reference.

165

		for ($i = 1; $i <= $trackDirectorSubmission->getCurrentStage(); $i++) {

165

		foreach (array(REVIEW_STAGE_ABSTRACT, REVIEW_STAGE_PRESENTATION) as $i) {

166

			$directorDecisions = $trackDirectorSubmission->getDecisions($i);

166

			$directorDecisions = $trackDirectorSubmission->getDecisions($i);

167

			$insertedDecision = false;

167

			$insertedDecision = false;

168

			if (is_array($directorDecisions)) {

168

			if (is_array($directorDecisions)) {

(-)pages/presenter/TrackSubmissionHandler.inc.php (-5 / +8 lines)

Lines 95-102	Link Here

		$templateMgr->assign_by_ref('revisedFile', $submission->getRevisedFile());

		$templateMgr->assign_by_ref('revisedFile', $submission->getRevisedFile());

		$templateMgr->assign_by_ref('suppFiles', $submission->getSuppFiles());

		$templateMgr->assign_by_ref('suppFiles', $submission->getSuppFiles());

		import('submission.trackDirector.TrackDirectorSubmission');

		// FIXME: Presenter code should not use track director object

		$templateMgr->assign_by_ref('directorDecisionOptions', TrackDirectorSubmission::getDirectorDecisionOptions());

		$trackDirectorSubmissionDao =& DAORegistry::getDAO('TrackDirectorSubmissionDAO');

100

		$trackDirectorSubmission =& $trackDirectorSubmissionDao->getTrackDirectorSubmission($submission->getPaperId());

101

		$templateMgr->assign_by_ref('directorDecisionOptions', $trackDirectorSubmission->getDirectorDecisionOptions());

100

102

101

		$templateMgr->assign('helpTopicId','editorial.authorsRole');

103

		$templateMgr->assign('helpTopicId','editorial.authorsRole');

102

		$templateMgr->display('presenter/submission.tpl');

104

		$templateMgr->display('presenter/submission.tpl');

Lines 150-158	Link Here

150

		$templateMgr->assign_by_ref('suppFiles', $presenterSubmission->getSuppFiles());

152

		$templateMgr->assign_by_ref('suppFiles', $presenterSubmission->getSuppFiles());

151

		$templateMgr->assign('lastDirectorDecision', $lastDecision);

153

		$templateMgr->assign('lastDirectorDecision', $lastDecision);

152

154

153

		// Bring in director decision options

155

		// FIXME: Presenter code should not use track director object

154

		import('submission.trackDirector.TrackDirectorSubmission');

156

		$trackDirectorSubmissionDao =& DAORegistry::getDAO('TrackDirectorSubmissionDAO');

155

		$templateMgr->assign_by_ref('directorDecisionOptions', TrackDirectorSubmission::getDirectorDecisionOptions());

157

		$trackDirectorSubmission =& $trackDirectorSubmissionDao->getTrackDirectorSubmission($presenterSubmission->getPaperId());

158

		$templateMgr->assign_by_ref('directorDecisionOptions', $trackDirectorSubmission->getDirectorDecisionOptions());

156

159

157

		// Determine whether or not certain features should be disabled (i.e. past deadline)

160

		// Determine whether or not certain features should be disabled (i.e. past deadline)

158

		$templateMgr->assign('mayEditPaper', PresenterAction::mayEditPaper($presenterSubmission));

161

		$templateMgr->assign('mayEditPaper', PresenterAction::mayEditPaper($presenterSubmission));




		$templateMgr->assign_by_ref('cancelsAndRegrets', $cancelsAndRegrets);
		$templateMgr->assign_by_ref('reviewFilesByStage', $reviewFilesByStage);
		$templateMgr->assign_by_ref('directorDecisions', $directorDecisions);
		$templateMgr->assign_by_ref('directorDecisionOptions', $submission->getDirectorDecisionOptions());
		$templateMgr->assign('rateReviewerOnQuality', $schedConf->getSetting('rateReviewerOnQuality'));

		import('submission.reviewAssignment.ReviewAssignment');

		$templateMgr->assign('rateReviewerOnQuality', $schedConf->getSetting('rateReviewerOnQuality'));
		$templateMgr->assign('showPeerReviewOptions', $showPeerReviewOptions);
		$templateMgr->assign_by_ref('tracks', $tracks->toArray());
		$templateMgr->assign_by_ref('directorDecisionOptions', $submission->getDirectorDecisionOptions());
		$templateMgr->assign_by_ref('lastDecision', $lastDecision);
		$templateMgr->assign_by_ref('directorDecisions', $directorDecisions);


		Request::redirect(null, null, null, 'submission', $paperId);
	}

	function recordDecision($args) {
		$paperId = Request::getUserVar('paperId');
		list($conference, $schedConf, $submission) = SubmissionEditHandler::validate($paperId, TRACK_DIRECTOR_ACCESS_REVIEW);

		$stage = $submission->getCurrentStage();

		$decision = Request::getUserVar('decision');
		$stage = (int) array_shift($args);
		list($conference, $schedConf, $submission) = SubmissionEditHandler::validate($paperId, TRACK_DIRECTOR_ACCESS_REVIEW);

		// If the director changes the decision on the first round to
		// something other than "invite" (or "accept" -- necessary?),
		// roll back to the abstract review stage.
		if (
			$submission->getCurrentStage() == REVIEW_STAGE_PRESENTATION &&
			$stage == REVIEW_STAGE_ABSTRACT
		) {
			$submission->setCurrentStage(REVIEW_STAGE_ABSTRACT);
			$submission->setSubmissionProgress(2);
			$stage = REVIEW_STAGE_ABSTRACT;

			// Now, unassign all reviewers from the paper review

				}
			}

			TrackDirectorAction::recordDecision($submission, $decision, $stage);
		} else {
			switch ($decision) {
				case SUBMISSION_DIRECTOR_DECISION_ACCEPT:
				case SUBMISSION_DIRECTOR_DECISION_INVITE:
				case SUBMISSION_DIRECTOR_DECISION_PENDING_REVISIONS:
				case SUBMISSION_DIRECTOR_DECISION_DECLINE:
					TrackDirectorAction::recordDecision($submission, $decision, $stage);
					break;
			}
		}

(-)pages/trackDirector/TrackDirectorHandler.inc.php (-2 / +2 lines)

Lines 253-261	Link Here

253

		SubmissionEditHandler::changeTypeConst();

253

		SubmissionEditHandler::changeTypeConst();

254

255

256

	function recordDecision() {

256

	function recordDecision($args) {

257

		import('pages.trackDirector.SubmissionEditHandler');

257

		import('pages.trackDirector.SubmissionEditHandler');

258

		SubmissionEditHandler::recordDecision();

258

		SubmissionEditHandler::recordDecision($args);

259

260

261

	function selectReviewer($args) {

261

	function selectReviewer($args) {

(-)templates/trackDirector/submission/directorDecision.tpl (-1 / +1 lines)

Lines 15-21	Link Here

<tr valign="top">

<tr valign="top">

	<td class="label" width="20%">{translate key="director.paper.selectDecision"}</td>

	<td class="label" width="20%">{translate key="director.paper.selectDecision"}</td>

	<td width="80%" class="value" colspan="2">

	<td width="80%" class="value" colspan="2">

		<form method="post" action="{url op="recordDecision"}">

		<form method="post" action="{url op="recordDecision" path=$stage}">

			<input type="hidden" name="paperId" value="{$submission->getPaperId()}" />

			<input type="hidden" name="paperId" value="{$submission->getPaperId()}" />

			<select name="decision" size="1" class="selectMenu"{if not $allowRecommendation} disabled="disabled"{/if}>

			<select name="decision" size="1" class="selectMenu"{if not $allowRecommendation} disabled="disabled"{/if}>

				{assign var=availableDirectorDecisionOptions value=`$submission->getDirectorDecisionOptions($currentSchedConf,$stage)`}

				{assign var=availableDirectorDecisionOptions value=`$submission->getDirectorDecisionOptions($currentSchedConf,$stage)`}

Return to bug 4913